Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify A[1, end] lowering with lastindex(A, n) #25763

Merged
merged 3 commits into from
Jan 27, 2018
Merged

Simplify A[1, end] lowering with lastindex(A, n) #25763

merged 3 commits into from
Jan 27, 2018

Commits on Jan 26, 2018

  1. Simplify A[1, end] lowering with lastindex(A, n) 

    This implements a new method of `lastindex` to specify a given dimension, and then uses that new method in the lowering of `end` within multi-dimensional indices.  Previously, this would have lowered directly to `last(axes(A, d))` for `end` in position `d`.  Given that `axes` (and multidimensional indexing generally) are array-centric concepts, I have only implemented this for `::AbstractArray`, with a deprecation for all other types suggesting implemention if sensible.  I have similarly defined `firstindex(A, d)` - it will be available for its syntax transformation in the future.
    @mbauman
    mbauman committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    afe134e View commit details
    Browse the repository at this point in the history

  2. Update NEWS.md

    @mbauman
    mbauman committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    7f3e69e View commit details
    Browse the repository at this point in the history

  3. Remove unpaired ) from comment

    @mbauman
    mbauman committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    19e6c45 View commit details
    Browse the repository at this point in the history