Deprecate diagmm in favor of scale #2918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you update the mentions in the docs too? |
|
@ViralBShah I thought that I did update the docs. Did I miss something? |
|
The wording in the docs is a bit weird. It should be clear in the first sentence that it's equivalent to multiplying with a diagonal matrix on the right. |
|
@dmbates I missed your doc updates, given that this small change touches so much. I see it now. |
ViralBShah
added a commit
that referenced
this pull request
Apr 24, 2013
Deprecate diagmm in favor of scale
|
@mlubin I have updated the docs as you suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #2916