Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log REPL output in contrib/generate_precompile.jl #30934

Closed
wants to merge 1 commit into from

Conversation

pfitzseb
Copy link
Member

@pfitzseb pfitzseb commented Feb 1, 2019

This PR catches a few cases that might cause the precompile sript to deadlock and also logs the REPL output to a file, which makes debugging errors much easier.

New output:

    JULIA usr/lib/julia/sys-o.a
Generating precompile statements (debug logging in /tmp/tmpvdRWG0)... 1050 generated in  91.869680 seconds (overhead  70.290100 seconds)
    LINK usr/lib/julia/sys.so

julia on  master [!] 
λ cat /tmp/tmpvdRWG0              
julia> 2+2
4

julia> print("")

julia> @time 1+1
  0.000004 seconds (32 allocations: 2.313 KiB)
2

shell>  pwd
/home/pfitzseb/Documents/Git/julia/base

help?>  reinterpret
search: reinterpret
...

cc @KristofferC

to make deadlock less likely and also log the REPL statements to a file 
to make debugging easier
@vtjnash vtjnash closed this Apr 12, 2021
@vtjnash
Copy link
Sponsor Member

vtjnash commented Apr 12, 2021

We've rewritten it a few times since here. Mostly we avoid the REPL now, except for a few cases such as testing the UI itself and controlling Pkg.

@pfitzseb pfitzseb deleted the sp/precompilelogging branch April 12, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants