sysimg: reduce the number of special cases (essentially NFC) #31948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
force-pushed
the
jn/simple_serialize
branch
2 times, most recently
from
bffbe40
to
cca9892
Compare
JeffBezanson
reviewed
May 8, 2019
src/datatype.c
Outdated
| @@ -624,7 +624,7 @@ void jl_assign_bits(void *dest, jl_value_t *bits) | |||
| #define PERMBOXN_FUNC(nb,nw) \ | |||
| jl_value_t *jl_permbox##nb(jl_datatype_t *t, int##nb##_t x) \ | |||
| { \ | |||
| assert(jl_isbits(t)); \ | |||
| /*assert(jl_isbits(t));*/ \ | |||
There was a problem hiding this comment.
Maybe just remove this?
JeffBezanson
reviewed
May 8, 2019
| &jl_builtin_apply_type, &jl_builtin_applicable, &jl_builtin_invoke, | ||
| &jl_builtin__expr, &jl_builtin_ifelse, | ||
| NULL }; | ||
| static jl_value_t **const*const tags = (jl_value_t**const*const)_tags; |
There was a problem hiding this comment.
A classic C type declaration 😂
JeffBezanson
reviewed
May 8, 2019
src/staticdata.c
Outdated
| for (i = 0; i < builtin_typenames.len; i++) { | ||
| jl_write_value(&s, ((jl_typename_t*)builtin_typenames.items[i])->cache); | ||
| jl_write_value(&s, ((jl_typename_t*)builtin_typenames.items[i])->linearcache); | ||
| // save module initialization order |
There was a problem hiding this comment.
Remove this comment?
JeffBezanson
reviewed
May 8, 2019
src/staticdata.c
Outdated
| @@ -1098,100 +1191,52 @@ static void jl_finalize_serializer(jl_serializer_state *s) | |||
|
|
|||
|
|
|||
| void jl_typemap_rehash(jl_typemap_t *ml, int8_t offs); | |||
JeffBezanson
reviewed
May 8, 2019
| assert(jl_is_mtable(mt)); | ||
| jl_typemap_rehash(mt->defs, 0); | ||
| // TODO: consider reverting this when we can split on Type{...} better | ||
| jl_typemap_rehash(mt->cache, 1); //(mt == jl_type_typename->mt) ? 0 : 1); |
There was a problem hiding this comment.
Interesting. Why were we doing this before?
There was a problem hiding this comment.
Probably got moved over from dump.c when this file split off, but this didn't get used.
JeffBezanson
approved these changes
May 8, 2019
Put the entire image(*) into our pre-constructed data image, instead of attempting to leave out a couple of items. This saves us a couple lines of code, and should makes it simpler to keep the list of builtin objects (gc.c "tags") up-to-date. (*) The remaining special objects are ptls->root_task, since I was unsure the best way to handle it as no other Task object is allowed to be referenced, and the small integer caches.
vtjnash
force-pushed
the
jn/simple_serialize
branch
from
a4a98d5
to
ea47a13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put the entire image(*) into our pre-constructed data image,
instead of attempting to leave out a couple of items.
This saves us a couple lines of code, and should makes it
simpler to keep the list of builtin objects (gc.c "tags") up-to-date.
(*) The remaining special objects are ptls->root_task,
since I was unsure the best way to handle it as no other Task
object is allowed to be referenced, and the small integer caches.