Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace != 0 with !iszero in sparse matrix constructions #32019

Closed
wants to merge 3 commits into from
Closed

Replace != 0 with !iszero in sparse matrix constructions #32019

wants to merge 3 commits into from

Conversation

ChrisRackauckas
Copy link
Member

!iszero works better in some generic contexts. Xref: SciML/ModelingToolkit.jl#133

@ChrisRackauckas
Replace != 0 with !iszero
94d7714 
!iszero works better in some generic contexts. Xref: SciML/ModelingToolkit.jl#133
@mbauman mbauman added the domain:arrays:sparse Sparse arrays label May 14, 2019
@mbauman
Copy link
Sponsor Member

mbauman commented May 14, 2019

See also #30580.

ChrisRackauckas and others added 2 commits May 15, 2019 19:49
@ChrisRackauckas @musm
Update stdlib/SparseArrays/src/sparsematrix.jl
892dcde 
Co-Authored-By: Mustafa M. <mus-m@outlook.com>
@ChrisRackauckas @musm
Update stdlib/SparseArrays/src/sparsematrix.jl
7bb9041 
Co-Authored-By: Mustafa M. <mus-m@outlook.com>
@ViralBShah
Copy link
Member

Nice PR! Need to get the tests passing.

@andreasnoack
Copy link
Member

Covered by #30580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@musm musm musm left review comments

@stevengj stevengj stevengj approved these changes

Assignees
No one assigned
Labels
domain:arrays:sparse Sparse arrays
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ChrisRackauckas @mbauman @ViralBShah @andreasnoack @stevengj @musm