fix codecov accuracy for optimized and dead statements #34254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
force-pushed
the
jn/codecov-accuracy
branch
from
1ca576a
to
202efeb
Compare
vtjnash
force-pushed
the
jn/codecov-accuracy
branch
from
202efeb
to
7cf6549
Compare
| codeloc = ci.codelocs[idx] | ||
| if coverage && codeloc != prevloc && codeloc != 0 | ||
| # insert a side-effect instruction before the current instruction in the same basic block | ||
| insert!(code, idx, Expr(:code_coverage_marker)) |
There was a problem hiding this comment.
:code_coverage_effect?
timholy
added a commit
to timholy/Revise.jl
that referenced
this pull request
Feb 4, 2020
Julia 1.5 introduced annotations to improve line-coverage analysis (see JuliaLang/julia#34254). We just have to make sure these don't contaminate our tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As people have noted (e.g #28192), Keno made the optimizer much too good. Rather than making the optimizer worse, we instead here preprocess the IR to inject a weak compiler barrier at each line change. This ensures we preserve the line number record, even if we drop all other side-effects at that point.