Modify recommended startup #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Passes for me locally (with JuliaPackaging/Requires.jl#78). Let's see if just trying the latest nightly fixes this. |
|
#%^*@! Can anyone replicate the failure locally? |
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
=========================================
- Coverage 81.26% 81.06% -0.2%
=========================================
Files 12 12
Lines 1505 1505
=========================================
- Hits 1223 1220 -3
- Misses 282 285 +3
Continue to review full report at Codecov.
|
Julia 1.5 introduced annotations to improve line-coverage analysis (see JuliaLang/julia#34254). We just have to make sure these don't contaminate our tests.
timholy
force-pushed
the
teh/docs_startup
branch
from
5c50253
to
2724703
Compare
|
Ah, it was triggered only by Awesome change BTW @vtjnash, look forward to seeing it change our coverage stats! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #415