compiler: more accurate isdefined_tfunc for NamedTuple arg:
#37830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
force-pushed
the
avi/isdefined4ntpl
branch
from
c5bd1ee
to
3e33267
Compare
Keno
reviewed
Oct 1, 2020
base/compiler/tfuncs.jl
Outdated
| else | ||
| ns = a1.parameters[1] | ||
| if isa(ns, Tuple) | ||
| return Const(val in ns) |
There was a problem hiding this comment.
So this happens when the NamedTuple is not concrete (e.g. because the types are not known), but the field names are known? Seems reasonable to me, but please add a test that tests this codepath (i.e. fails without this commit and passes with it).
There was a problem hiding this comment.
So this happens when the NamedTuple is not concrete (e.g. because the types are not known), but the field names are known?
yeah, exactly.
I will try to add a test later
There was a problem hiding this comment.
This should use 1 <= idx <= length(ns).
There was a problem hiding this comment.
nice, applied in 8823625
aviatesk
force-pushed
the
avi/isdefined4ntpl
branch
from
fbf0f07
to
374b7f9
Compare
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Oct 1, 2020
once JuliaLang/julia#37830 gets merged, this test should pass
aviatesk
force-pushed
the
avi/isdefined4ntpl
branch
from
374b7f9
to
8823625
Compare
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Oct 2, 2020
once JuliaLang/julia#37830 gets merged, this test should pass
aviatesk
force-pushed
the
avi/isdefined4ntpl
branch
from
8823625
to
762a1dd
Compare
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Oct 3, 2020
once JuliaLang/julia#37830 gets merged, this test should pass
e.g.
this will exclude unnecessary runtime calls of `haskey` when a keyword
argument is inferred as non-concrete type
```julia
f(a; b = nothing, c = nothing) = return
let
b = rand((nothing,1,1.))
f(0; b)
end
```
aviatesk
force-pushed
the
avi/isdefined4ntpl
branch
from
762a1dd
to
5464a9a
Compare
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Oct 8, 2020
once JuliaLang/julia#37830 gets merged, this test should pass
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Oct 8, 2020
once JuliaLang/julia#37830 gets merged, this test should pass
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Oct 8, 2020
once JuliaLang/julia#37830 gets merged, this test should pass
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Oct 8, 2020
once JuliaLang/julia#37830 gets merged, this test should pass
|
@JeffBezanson @Keno can you have a review on this again ? |
|
Nice improvement! |
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Oct 9, 2020
once JuliaLang/julia#37830 gets merged, this test should pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will help the compiler, e.g. exclude unnecessary runtime calls of
haskeywhen a keyword argument is inferred as non-concrete type