Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make lowrankupdate/downdate more permissive #39150

Merged
merged 2 commits into from
Jan 10, 2021

Conversation

bicycle1885
Copy link
Member

@bicycle1885 bicycle1885 commented Jan 8, 2021

This makes lowrankupdate and lowrankdowndate function arguments more permissive. The following code didn't work because StaticArray was not a subtype of DenseArray.

using StaticArrays
using LinearAlgebra
A = @MMatrix [1.0 0.0; 0.0 1.0]
C = cholesky(A)
lowrankupdate(C, @MVector [1.0, 2.0])

@stevengj
Copy link
Member

stevengj commented Jan 9, 2021

Can we have a test? e.g. use a range

@stevengj stevengj added the domain:linear algebra Linear algebra label Jan 9, 2021
@bicycle1885
Copy link
Member Author

Thank you for your comment. I've added test cases for a new abstract vector type (ranges are not usable in this case because they are immutable) and slightly cleaned up the test code.

@dkarrasch dkarrasch merged commit 927c9fa into JuliaLang:master Jan 10, 2021
@bicycle1885 bicycle1885 deleted the lowrankupdate branch January 10, 2021 18:57
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
* make lowrankupdate/downdate more permissive

* add tests for abstract vectors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants