Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine and cleanup handling of range arithmetic #43360

Merged
merged 2 commits into from
Dec 10, 2021
Merged

refine and cleanup handling of range arithmetic #43360

merged 2 commits into from
Dec 10, 2021

Commits on Dec 7, 2021

  1. [Dates] define arithmetic promotion for more operators

    @vtjnash
    vtjnash committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    bdf9ead View commit details
    Browse the repository at this point in the history

  2. refine and cleanup handling of range arithmetic 

    Try to be more careful about which types we use for arguments and return
values and comparisons in intermediate computations. Not expected to
change nominal behaviors, but may improve some unusual ranges that
require some conversions or are near over/underflow.

And use convert(T,1) rather than oneunit(T) to support fewer types, as
we want the default step to be a unitless 1 (e.g., not Nanosecond(1)).

Replaces #43058
    @vtjnash
    vtjnash committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    ff185b7 View commit details
    Browse the repository at this point in the history