refine and cleanup handling of range arithmetic #43360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to be more careful about which types we use for arguments and return values and comparisons in intermediate computations. Not expected to change nominal behaviors, but may improve some unusual ranges that require some conversions or are near over/underflow. And use convert(T,1) rather than oneunit(T) to support fewer types, as we want the default step to be a unitless 1 (e.g., not Nanosecond(1)). Replaces #43058
vtjnash
force-pushed
the
jn/ranges-last
branch
from
75f1cf0
to
ff185b7
Compare
This was referenced Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #43058