Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base.runtests: unset JULIA_PROJECT and JULIA_LOAD_PATH #43575

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

DilumAluthge
Copy link
Member

Closes #43574

This is a follow-up to #42358.

@DilumAluthge DilumAluthge added test This change adds or pertains to unit tests testsystem The unit testing framework and Test stdlib backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Dec 28, 2021
@DilumAluthge
Copy link
Member Author

@mkitti Can you test this out locally and confirm that it fixes your use case?

@mkitti
Copy link
Contributor

mkitti commented Dec 28, 2021

It works with 91b8f0c.

$ JULIA_PROJECT="@foobar" JULIA_LOAD_PATH="@:@foobar:@stdlib" usr/bin/julia -e 'Base.runtests(["loading","cmdlineargs"])'
Test    (Worker) | Time (s) | GC (s) | GC % | Alloc (MB) | RSS (MB)
loading      (2) |        started at 2021-12-28T15:38:52.203
cmdlineargs  (3) |        started at 2021-12-28T15:38:52.305
      From worker 2:	┌ Error: active project callback #19 failed
      From worker 2:	└ @ Base initdefs.jl:325
      From worker 2:	WARNING: replacing module Foo.
loading      (2) |    25.21 |   0.59 |  2.4 |    1959.53 |   367.73
cmdlineargs  (3) |   228.90 |   0.45 |  0.2 |     819.24 |   343.24

Test Summary: |   Pass  Broken   Total     Time
  Overall     | 145913       3  145916  3m52.4s
    SUCCESS
$ JULIA_PROJECT="@foobar" JULIA_LOAD_PATH="@:@foobar:@stdlib" usr/bin/julia -e 'using InteractiveUtils; versioninfo()'
Julia Version 1.8.0-DEV.1183
Commit 91b8f0c1de* (2021-12-28 10:31 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: AMD FX(tm)-8350 Eight-Core Processor
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, bdver1)
Environment:
  JULIA_LOAD_PATH = @:@foobar:@stdlib
  JULIA_PROJECT = @foobar
  JULIA_CPU_TARGET = generic;native

@DilumAluthge DilumAluthge merged commit f61eb87 into master Dec 28, 2021
@DilumAluthge DilumAluthge deleted the dpa/runtests-unset-env-vars branch December 28, 2021 20:48
@mkitti
Copy link
Contributor

mkitti commented Dec 28, 2021

While I do think this is simpler, I still do think we should annotate the appropriate tests that they are dependent on having default values for JULIA_PROJECT and JULIA_LOAD_PATH. I also note that this make it harder to test the effects of changing these variables on all the other tests where they should have no effect.

KristofferC pushed a commit that referenced this pull request Jan 5, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
KristofferC pushed a commit that referenced this pull request Mar 15, 2022
KristofferC pushed a commit that referenced this pull request Mar 16, 2022
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label May 16, 2022
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This change adds or pertains to unit tests testsystem The unit testing framework and Test stdlib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants