Fix skipped range test #44384
Closed
Fix skipped range test #44384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I recall this being unreliable when I was messing with range code recently. I was also not entirely sure this test was even reasonable. |
|
Ok. It's failing on buildkite linux32 and linux64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
92% of the 352656 "Broken" tests in Base are attributed with this
@test_skip, which seems like it was meant to be un-skipped in #43360 where it was channged to a≈and passes locally when un-skipped.It's not addressed in this PR but the next biggest chunk are the 24795
@test_broken's intest/abstractarray.jljulia/test/abstractarray.jl
Line 1160 in 394af38
I point this out because between both, that's 99.95% of tests marked as "Broken", which seems a bit disproportionate