refactor syntax tests slightly #45081
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is pulled out from #44989. Making `test_parseerror` a macro leads to much more helpful stacktraces if something fails.
simeonschaub
added
status:merge me
vtjnash
reviewed
Apr 25, 2022
Comment on lines
+321
to
+322
| ex = :(@test_throws ParseError($(esc(msg))) Meta.parse($(esc(str)))) | ||
| ex.args[2] = __source__ |
There was a problem hiding this comment.
@JeffBezanson this is an example of why we needed #44995, since the ex object here fails to track the top-level line number after all of the code expansion
vtjnash
removed
the
status:merge me
|
Included in #44989 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pulled out from #44989. Making
test_parseerrora macro leadsto much more helpful stacktraces if something fails.