Support invoke backedges for const (fix #44320)
#46715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that writing "fix #issue" won't actually link the PR to the issue. The magic text should go into the commit message body and/or the description of the PR. GitHub doesn't even linkify "fix #issue" in the title of a PR, so doing that will make it harder to actually visit the mentioned issue. |
vtjnash
added
the
status:merge me
DilumAluthge
removed
the
status:merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a left-over piece of #46010, triggered by const args.
I am not certain this is all of them, might there be other paths to
add_backedge!that we're not passing downinvoketypesto? The issue is that in the case of aninvokebackedge, not only do we have to add the proper signature-"decorated" backedge, we have to be sure we don't add the undecorated variant. Otherwise the caller will be invalidated even though the decorated backedge remains valid.Fixes #44320