Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redo of "Add ability to add output prefixes to the REPL output and use that to implement an IPython mode" #46781

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Redo of "Add ability to add output prefixes to the REPL output and use that to implement an IPython mode" #46781

merged 2 commits into from
Sep 19, 2022

Conversation

KristofferC
Copy link
Sponsor Member

Original PR (#46474) had to be reverted due to a change in a signature that happened after CI ran on that PR.

@KristofferC KristofferC added the stdlib:REPL Julia's REPL (Read Eval Print Loop) label Sep 15, 2022
rfourquet
rfourquet reviewed Sep 15, 2022
View reviewed changes
stdlib/REPL/src/REPL.jl Outdated Show resolved Hide resolved
@KristofferC KristofferC force-pushed the kc/output_prompts branch 2 times, most recently from 6238a64 to 07a2728 Compare September 16, 2022 09:49
@KristofferC KristofferC merged commit 21e8c7c into master Sep 19, 2022
@KristofferC KristofferC deleted the kc/output_prompts branch September 19, 2022 08:16
This was referenced Sep 19, 2022
Closed
Closed
@vtjnash vtjnash mentioned this pull request Oct 19, 2022
Merged
@PallHaraldsson
Copy link
Contributor

Is it confusing (for the future) to call it an "IPython mode"?

Should it be "Jupyter mode" and module? That's what used in Julia, and IPython implementation detail, or is it even still used (or will forever)? If Jupyter is a better term, then change before 1.9 get released...

@KristofferC
Copy link
Sponsor Member Author

Should it be "Jupyter mode"

Why would it be called that?

@PallHaraldsson
Copy link
Contributor

I'm not sure, I know about IPython and the history sort of. I thought Jupyter replaced IPython practically, for notebook users that would be what they know.

If this is only about numbered mode then maybe call it "Pluto mode" or just "numbered mode"?

@StefanKarpinski
Copy link
Sponsor Member

IPython still exists but is now a Python-specific REPL. This makes the Julia REPL a bit more like IPython.

@KristofferC
Copy link
Sponsor Member Author

I thought Jupyter replaced IPython practically,

https://github.com/ipython/ipython

If this is only about numbered mode then maybe call it "Pluto mode" or just "numbered mode"?

It is not, it is about being like IPython, hence "IPython mode" :).

@terasakisatoshi terasakisatoshi mentioned this pull request Dec 11, 2022
Closed
@hyrodium
Copy link
Sponsor Contributor

@PallHaraldsson
I overlooked that there was already a discussion about the naming of this feature. I still think it's better to rename this feature, and opened a PR (#49314). Please comment in the PR if you have any thoughts on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfourquet rfourquet rfourquet left review comments

Assignees
No one assigned
Labels
stdlib:REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@KristofferC @PallHaraldsson @StefanKarpinski @hyrodium @rfourquet