Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't export axp(b)y! from LinearAlgebra.BLAS #46851

Merged
merged 2 commits into from
Oct 8, 2022
Merged

Don't export axp(b)y! from LinearAlgebra.BLAS #46851

merged 2 commits into from
Oct 8, 2022

Conversation

dkarrasch
Copy link
Member

Closes #46822, following #46822 (comment). This probably requires a nanosoldier run. Tests pass locally.

@dkarrasch dkarrasch added the domain:linear algebra Linear algebra label Sep 21, 2022
@giordano giordano added the needs pkgeval Tests for all registered packages should be run with this change label Sep 21, 2022
@dkarrasch
Copy link
Member Author

@nanosoldier runtests(ALL, vs = ":master")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@dkarrasch
Copy link
Member Author

Looks good, I couldn't find related test failures, but let's run the few failing packages again.

@nanosoldier runtests(["Catlab", "CombinatorialSpaces", "CountdownNumbers", "Dolo", "DrelTools", "Evolutionary", "FlameGraphs", "Folds", "GraphMLDatasets", "IntervalLinearAlgebra", "MCVI", "MIPVerify", "NeXLCore", "ObjectivePaths", "Permanents", "Pidfile", "PlotPlants", "PowerWaterModels", "QuadraticToBinary", "RAPIDS", "RegularizedLeastSquares", "RetroCap", "SodShockTube", "SunAsAStar", "Tullio", "WorldOceanAtlasTools"], vs = ":master")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@dkarrasch dkarrasch marked this pull request as ready for review September 29, 2022 08:25
@dkarrasch dkarrasch merged commit 0d90a0a into master Oct 8, 2022
@dkarrasch dkarrasch deleted the dk/blas branch October 8, 2022 08:30
@maleadt maleadt mentioned this pull request Jan 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
domain:linear algebra Linear algebra needs pkgeval Tests for all registered packages should be run with this change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

axpby! exported twice
3 participants
@dkarrasch @nanosoldier @giordano