Allow reentrant Inference profiling. #47260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @vilterp |
NHDaly
force-pushed
the
nhd-snoopi_deep-logical-race-disable-timing
branch
from
3f564d5
to
0063ad6
Compare
Change start/stop measuring type inference timings to an atomic counter. This allows multiple tasks to start timing and then all stop timing, without the timing being disabled by the first tasks to finish.
NHDaly
force-pushed
the
nhd-snoopi_deep-logical-race-disable-timing
branch
from
0063ad6
to
a97af06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #47258.
Change start/stop measuring type inference timings to an atomic counter.
This allows multiple tasks to start timing and then all stop timing, without the timing being disabled by the first tasks to finish.
I'm not entirely sure if this Atomic Int is overkill.. 🤔 maybe we should just grab the inference lock when we update the integer? I'm also not sure if this will pass bootstrap or not. We'll see when it builds, i guess.
I also left the old
__set_measure_typeinf(onoff::Bool)function, rather than deleting it, so that this wouldn't be a backwards-incompatible breaking change, breaking older versions of SnoopCompile.jl. I wanted to mark the function with@deprecate, but it seems to not be available from `Core.Compiler.