Backports for Julia 1.8.4 #47488
Merged
Backports for Julia 1.8.4 #47488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gabriel Baraldi <baraldigabriel@gmail.com> (cherry picked from commit 9e1dac0)
…hefile (#47433) * CircleCI caching: allow ftime to be ceil(ftime_req) in Base.stale_cachefile It appears that [caching functionalities](https://circleci.com/docs/caching/) provided by CircleCi, a leading CI/CD provider, can truncate timestamps to full seconds, resulting in re-compilations as below: ``` Rejecting stale cache file /root/.julia/compiled/v1.8/ComponentArrays/cYHSD_3rQji.ji (mtime 1.6673960929277816e9) because file /root/.julia/packages/ComponentArrays/YyD7i/src/ComponentArrays.jl ``` This PR relaxes the `is_stale` check to be robust against rounding-to-second timestamp mutations. I can provide a minimal CircleCI configuration file to reproduce if this is helpful. (cherry picked from commit bf92e83)
DilumAluthge
force-pushed
the
backports-release-1.8
branch
from
9861bf1
to
b66e38c
Compare
|
I'd like to get JuliaCI/julia-buildkite#259 merged before this PR is merged. This will allow Buildkite to upload |
* Probe if system libstdc++ is newer than ours If the system libstdc++ is detected to be newer, load it. Otherwise, load the one that we ship. This improves compatibility with external shared libraries that the user might have on their system. Fixes #34276 Co-authored-by: Jameson Nash <vtjnash@gmail.com> Co-authored-by: Elliot Saba <staticfloat@gmail.com> * Addressed review comments. * Change error handling in wrapper functions Co-authored-by: Jameson Nash <vtjnash@gmail.com> * Call write_wrapper three times instead of snprintf Co-authored-by: Jameson Nash <vtjnash@gmail.com> * Apply suggestions from code review Co-authored-by: Jameson Nash <vtjnash@gmail.com> * Update cli/loader_lib.c Co-authored-by: Jameson Nash <vtjnash@gmail.com> * Reordered reading and waiting to avoid a deadlock. * Fixed obvious issues. * Only load libstdc++ preemptively on linux. * Update cli/loader_lib.c Co-authored-by: Jameson Nash <vtjnash@gmail.com> * Update cli/loader_lib.c Co-authored-by: Jameson Nash <vtjnash@gmail.com> * Specified path to bundled libstdc++ on the command line. * Removed whitespace. * Update cli/Makefile Co-authored-by: Jameson Nash <vtjnash@gmail.com> * Handled make install stringreplace. * Correctly quoted stringreplace. * Added -Wl,--enable-new-dtags to prevent DT_RPATH for transitive dependencies * Updated news entry. * Added comment about environment variable. * patched rpath for libgfortran and libLLVM. * Added explaination to Make.inc * Removed trailing space * Removed patchelf for libgfortran, now that BB has been fixed. * Fixed typos and comments Co-authored-by: Max Horn <max@quendi.de> Co-authored-by: Mosè Giordano <mose@gnu.org> Co-authored-by: Jameson Nash <vtjnash@gmail.com> Co-authored-by: Elliot Saba <staticfloat@gmail.com> Co-authored-by: Max Horn <max@quendi.de> (cherry picked from commit eb708d6)
* Limit initial OpenBLAS thread count We set OpenBLAS's initial thread count to `1` to prevent runaway allocation within OpenBLAS's initial thread startup. LinearAlgebra will later call `BLAS.set_num_threads()` to the actual value we require. * Support older names (cherry picked from commit 58b559f)
(cherry picked from commit bba41d4)
KristofferC
force-pushed
the
backports-release-1.8
branch
3 times, most recently
from
e82fcbf
to
48f11e9
Compare
|
@nanosoldier |
This comment was marked as outdated.
This comment was marked as outdated.
KristofferC
force-pushed
the
backports-release-1.8
branch
from
48f11e9
to
a9a234c
Compare
The command-line program `rm` has no problem deleting an empty directory
that we do not have listing permissions on, so we should follow suit.
Example:
```
mktempdir() do dir
mkpath("$(dir)/foo")
chmod("$(dir)/foo", 0o200)
rm(dir; recursive=true)
end
```
(cherry picked from commit d0a211a)
(cherry picked from commit 7514bcf)
`b->name` is used to lookup in `b->owner`, not `var`. (cherry picked from commit dbe41d4)
This code was introduced by me back in #31025 to speed up evaluation of generated functions that didn't make use of all of their arguments to make generation decisions. However, it neglected to take into account the possibility that the generator could be varargs. As a result, an unfortunate coincidence of an unused slot in the correct position could have allowed expansion of generators that were not supposed to be expandable. This can cause incorrect inference with all the usual consequences. However, fortunately this coincidence appears to be pretty rare. Fixes JuliaDebug/CassetteOverlay.jl#12 (cherry picked from commit 328dd57)
(cherry picked from commit 0feaf5c)
(cherry picked from commit 5a6c808)
This fixes some issues around macro hygiene in `global` expressions. Apparently we always treat l-values in global expressions as being escaped, but we still need to be careful to handle type annotations and destructuring correctly. (cherry picked from commit cc25a13)
This should prevent LinearAlgebra from trying to increase our OpenBLAS thread count in its `__init__()` method when we're not trying to enable threaded BLAS. (cherry picked from commit a8b3994)
KristofferC
force-pushed
the
backports-release-1.8
branch
from
a9a234c
to
fd92d74
Compare
[release 1.8] backport of precompile: serialize the full edges graph (#46920)
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
|
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. |
|
The PkgEval failures are due to QuantumBFS/LuxurySparse.jl#72. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported PRs:
@test_throws#45893.github/workflows/rerun_failed.yml#47460elseifand short-circuit op #47499rm(; recursive=true)should ignoreUV_EACCES#47668mul!for vectors of vectors #47665globalexpressions #47719OPENBLAS_NUM_THREADS=1on local Distributed workers #47803Need manual backport:
Contains multiple commits, manual intervention needed:
Non-merged PRs with backport label:
create_expr_cache#46801