Use fld
in _colon
method in range.jl
, rather than floating point division
#48654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces calls to
floor(Integer, a / b)
withfld(a, b)
in_colon()
, resulting in simpler and more efficient generated code.The
convert(Integer, ...)
is necessary, otherwise the following test fails:julia/test/ranges.jl
Lines 1524 to 1527 in d8c2250
with
I was surprised at first that
cld(::BigFloat, ::BigFloat)
returns aBigFloat
rather than aBigInt
, buton second thought, I believe the current behavior is indeed appropriate, as there is nothing to say thatthis is consistent withBigInt
andBigFloat
are set to the same precisioncld(::Float64, ::Float64)
returning aFloat64
(see thecld
docstring). Hence theconvert
call in this PR to ensure the returned value is still anInteger
.