delay loading of extensions as much as possible #48674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
added
domain:packages
vtjnash
reviewed
Feb 16, 2023
KristofferC
force-pushed
the
kc/ext_loading_2
branch
from
de7a7e7
to
0fd670f
Compare
vtjnash
reviewed
Mar 13, 2023
base/loading.jl
Outdated
Comment on lines
1208
to
1209
| for pkgid in copy(keys(EXT_DORMITORY)) | ||
| haskey(Base.loaded_modules, pkgid) || continue |
There was a problem hiding this comment.
would this be any better?
Suggested change
| for pkgid in copy(keys(EXT_DORMITORY)) | |
| haskey(Base.loaded_modules, pkgid) || continue | |
| for pkgid in intersect(keys(Base.loaded_modules), keys(Base.EXT_DORMITORY)) |
I also wonder if there is any meaningful way to sort this list to be predictable (if that is worthwhile to do), for example we could try to sort the result, but isless(::Base.PkgId, ::Base.PkgId) is not defined.
There was a problem hiding this comment.
I did this and also sorted by UUID.
There was a problem hiding this comment.
I hope folks don't decide to give their packages low or high uuids to hack trigger order.
There was a problem hiding this comment.
Doesn't really matter, this is just to keep it consistent.
oscardssmith
pushed a commit
to oscardssmith/julia
that referenced
this pull request
Mar 20, 2023
KristofferC
added a commit
that referenced
this pull request
Mar 24, 2023
(cherry picked from commit e3043a8)
KristofferC
pushed a commit
that referenced
this pull request
Apr 5, 2023
This reverts commit e3043a8.
KristofferC
pushed a commit
that referenced
this pull request
Apr 5, 2023
This reverts commit e3043a8.
KristofferC
pushed a commit
that referenced
this pull request
Apr 9, 2023
This reverts commit e3043a8.
KristofferC
pushed a commit
that referenced
this pull request
Apr 9, 2023
This reverts commit e3043a8.
KristofferC
pushed a commit
that referenced
this pull request
Apr 9, 2023
This reverts commit e3043a8.
KristofferC
added a commit
that referenced
this pull request
Apr 9, 2023
Revert "delay loading of extensions as much as possible (#48674)"
KristofferC
pushed a commit
that referenced
this pull request
Apr 9, 2023
Xnartharax
pushed a commit
to Xnartharax/julia
that referenced
this pull request
Apr 19, 2023
Xnartharax
pushed a commit
to Xnartharax/julia
that referenced
this pull request
Apr 19, 2023
)" This reverts commit e3043a8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Diff best viewed with whitespace ignored).
To reduce the likelihood of cycles, we delay loading extensions until all packages have finished loading during a
requirecall and we are ready to return to Main.Fixes #48533