Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move out LazyArtifacts from the sysimage #49130

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

KristofferC
Copy link
Sponsor Member

Doesn't seem to be a need to have this in the sysimage, it loads pretty much instantly and it blocks Pkg (which it depends on) from potentially being moved out in the future.

@KristofferC KristofferC added the stdlib Julia's standard library label Mar 24, 2023
@KristofferC
Copy link
Sponsor Member Author

KristofferC commented Mar 25, 2023

I'm guessing the

Executing tests that run on node 1 only:
--
  | precompile                                        (1) \|        started at 2023-03-24T19:38:36.778
  | err = Base.IOError("rm(\"C:\\\\Users\\\\julia\\\\AppData\\\\Local\\\\Temp\\\\jl_q1scxz\\\\compiled\\\\v1.10\"): directory not empty (ENOTEMPTY)", -4051)
  | err = Base.IOError("rm(\"C:\\\\Users\\\\julia\\\\AppData\\\\Local\\\\Temp\\\\jl_Nk8wFN\\\\compiled\\\\v1.10\"): directory not empty (ENOTEMPTY)", -4051)
  | err = Base.IOError("rm(\"C:\\\\Users\\\\julia\\\\AppData\\\\Local\\\\Temp\\\\jl_nWIHS2\\\\compiled\\\\v1.10\"): directory not empty (ENOTEMPTY)", -4051)
  | err = Base.IOError("rm(\"C:\\\\Users\\\\julia\\\\AppData\\\\Local\\\\Temp\\\\jl_yCg9X1\\\\compiled\\\\v1.10\"): directory not empty (ENOTEMPTY)", -4051)
  | err = Base.IOError("rm(\"C:\\\\Users\\\\julia\\\\AppData\\\\Local\\\\Temp\\\\jl_DQ8z37\\\\compiled\\\\v1.10\"): directory not empty (ENOTEMPTY)", -4051)
  | err = Base.IOError("rm(\"C:\\\\Users\\\\julia\\\\AppData\\\\Local\\\\Temp\\\\jl_gYRGjG\\\\jl_ZO1kR7\\\\compiled\\\\v1.10\"): directory not empty (ENOTEMPTY)", -4051)
  | err = Base.IOError("rm(\"C:\\\\Users\\\\julia\\\\AppData\\\\Local\\\\Temp\\\\jl_0Ct5Xb\\\\compiled\\\\v1.10\"): directory not empty (ENOTEMPTY)", -4051)
  | err = Base.IOError("rm(\"C:\\\\Users\\\\julia\\\\AppData\\\\Local\\\\Temp\\\\jl_xR1kBU\\\\compiled\\\\v1.10\"): directory not empty (ENOTEMPTY)", -4051)

on windows CI is relevant..

@staticfloat
Copy link
Sponsor Member

I think that's an unrelated issue, we see that every now and then. I re-ran the job, and now it looks all green, despite those errors still existing.

@KristofferC KristofferC merged commit 8be6f0f into master Apr 5, 2023
@KristofferC KristofferC deleted the kc/lazy_artifacts_sysimage branch April 5, 2023 06:53
Xnartharax pushed a commit to Xnartharax/julia that referenced this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stdlib Julia's standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants