Backports for 1.9.0 #49302

KristofferC · 2023-04-09T15:26:12Z

Backported PRs:

Need manual backport:

Non-merged PRs with backport label:

(cherry picked from commit 88a1fc7)

(cherry picked from commit 9001ea0)

(cherry picked from commit 1eee6ef)

same for symlinks, adjust docs accordingly and clarify that it refers to the mtime (cherry picked from commit 93df7e2)

(cherry picked from commit bd1a664)

Changes [Distributed._default_worker_pool](https://github.com/JuliaLang/julia/blob/5f5d2040511b42ba74bd7529a0eac9cf817ad496/stdlib/Distributed/src/workerpool.jl#L242) to hold an `AbstractWorkerPool` instead of `WorkerPool`. With this, alternate implementations can be plugged in as the default pool. Helps in cases where a cluster is always meant to use a certain custom pool. Lower level calls can then work without having to pass a custom pool reference with every call. (cherry picked from commit def2dda)

We generally hit the runtime in pretty specific places when allocations look funky (because they are missing a typevar bound, so inference is not too willing to deal with it). Try to throw an error in those cases before those can get allocated and cause problems later from being non-concrete objects. Fix #49203 (cherry picked from commit a1013e7)

This reverts commit e3043a8. (cherry picked from commit bf379e2)

(cherry picked from commit aa16cea)

Disambiguate scope of the `wp` variable inside `try`-`catch` in distributed tests by qualifying it and suppress the warning reported in the tests. fixes #49289 (cherry picked from commit 4ccaa1b)

This release of libblastrampoline contains two new features: ILP64 Accelerate support, and LAPACK_jll support. (cherry picked from commit 4ced71a)

This changes the behavior of `select_platform()` to resolve ambiguities using a two-step process. Previously, we would simply sort the resultant triplets and return the last one (so as to provide asemi- arbitrary stability, and also to prefer higher version numbers over lower version numbers in tags). However, with the proliferation of tags (and especially the new `sanitize=memory` tags) we need a way to exclude these "extra" tags when our `HostPlatform()` does not have them. This new matching algorithm excludes candidates from matching with the platform if there are other candidates with fewer total tags. This results in a "simplest match first" behavior, which better represents the intent of tags in the first place. (cherry picked from commit 99938fc)

…n run the event loop (#49094) (cherry picked from commit 9ed4087)

Subtype: skip more identical check for `X::Tuple <: Y::Tuple` (cherry picked from commit e3dfcc3)

Fix imaging value for generating sysimages for multiple targets (cherry picked from commit fc4b079)

KristofferC · 2023-04-13T14:12:02Z

@nanosoldier runtests(ALL, vs = "@7b395153e80672f8cdb18f51dd653a85e28b2070", configuration = (buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],), vs_configuration=(buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],))

nanosoldier · 2023-04-13T22:25:16Z

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

(cherry picked from commit fdd71c7)

Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com> Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com> (cherry picked from commit 99c0dad)

KristofferC · 2023-04-14T06:31:26Z

@nanosoldier runtests(["OnlineStats", "Recommenders", "RCall", "DocumenterCitations", "SharedMATLABEngine", "StateSpaceSets", "MCMCChains", "Reactive", "BifurcationInference", "Plots", "Mitosis", "Expronicon", "Arrow", "Unitful", "GeometricIntegrators", "CrystalInfoFramework", "PlasmoPlots", "AesKeywrapNettle", "ApproximateGPs", "RAPIDS", "VortexLattice", "AdmittanceModels", "MINLPTests", "PlasmaEquilibriumToolkit", "SPICE", "RadiationSpectra", "KiteModels", "DimensionalData", "AnyMOD"], vs = ":release-1.9", configuration = (buildflags = ["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],), vs_configuration = (buildflags = ["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],))

nanosoldier · 2023-04-14T15:20:37Z

Your package evaluation job has completed - no new issues were detected.
A full report can be found here.

KristofferC · 2023-04-15T18:02:55Z

The instruction dominates all uses errors in PkgEval are the same as #48918 and got "introduced" in fe72f81 when they actually started getting checked.

fix #47606 (cherry picked from commit 553047f)

timholy · 2023-04-16T11:25:21Z

Is skipping verification a viable "solution" on 1.9?

KristofferC · 2023-04-16T11:39:38Z

Not really (it only shows up when building with asserts anyway) , but we might just have to release without that fixed (it's really a LLVM bug from what I understand).

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>

(cherry picked from commit 74a52cf)

* Improve `simple_meet` resolution. * Fix for many-to-one cases. * Test disjoint via `jl_has_empty_intersection`

Co-authored-by: Sukera <Seelengrab@users.noreply.github.com> (cherry picked from commit 4beea98)

(cherry picked from commit bb118c9)

* Add missing entry to invalidation log Addresses timholy/SnoopCompile.jl#357 (comment) using the observation in the following comment. Co-authored-by: Jameson Nash <vtjnash@gmail.com> * Fix indentation --------- Co-authored-by: Jameson Nash <vtjnash@gmail.com> (cherry picked from commit 23a5b04)

(cherry picked from commit b1c0eac)

KristofferC · 2023-04-22T19:57:59Z

@nanosoldier runtests(ALL, vs = "@7b395153e80672f8cdb18f51dd653a85e28b2070", configuration = (buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],), vs_configuration=(buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],))

nanosoldier · 2023-04-23T10:54:23Z

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

1. remove duplicated disjoint check. 2. add a fast path for all disjoint case. (cherry picked from commit f2560c2)

This is the same as #45765 where we use `jl_error()` too early to get backtraces, but too late to fail the supposed guard `if` statement that should prevent us from trying to take a backtrace. X-ref: #45847 (cherry picked from commit fa21589)

[release-1.9] Avoid usage of `jl_error()` in `check_cmdline()`

…ia-internal` (#49442)

KristofferC · 2023-04-25T14:28:21Z

I'm gonna merge this since it is green to get a new "checkpoint". There are some other small thing that should go in but I'll do that in a different PR.

jishnub and others added 15 commits April 9, 2023 17:24

Offset to indices in (unsafe_)copyto docstring (#49147)

4e7a55e

(cherry picked from commit 88a1fc7)

allow more statements in generate_precompile.jl (#49200)

8219ad5

(cherry picked from commit 9001ea0)

Make :open ccall use variadic cconv (#49212)

c9596ef

(cherry picked from commit 1eee6ef)

(re-)allow include_dependency(directory) (#49244)

f8a4a37

same for symlinks, adjust docs accordingly and clarify that it refers to the mtime (cherry picked from commit 93df7e2)

Fix LazyString building with non-ASCII preceding $ (#49248)

ab206cb

(cherry picked from commit bd1a664)

Revert "delay loading of extensions as much as possible (#48674)"

ba9c797

This reverts commit e3043a8. (cherry picked from commit bf379e2)

add a test that extension is available during precompilation

b82c5db

(cherry picked from commit aa16cea)

fix new scope assignment warning in Distributed (#49303)

0d28812

Disambiguate scope of the `wp` variable inside `try`-`catch` in distributed tests by qualifying it and suppress the warning reported in the tests. fixes #49289 (cherry picked from commit 4ccaa1b)

Bump to LBT v5.7.0 (#49281)

4498251

This release of libblastrampoline contains two new features: ILP64 Accelerate support, and LAPACK_jll support. (cherry picked from commit 4ced71a)

make thread 1 interactive when there is an interactive pool, so it ca…

be1c71d

…n run the event loop (#49094) (cherry picked from commit 9ed4087)

Merge pull request #48534 from N5N3/Test2

eb764cc

Subtype: skip more identical check for `X::Tuple <: Y::Tuple` (cherry picked from commit e3dfcc3)

Merge pull request #48809 from ven-k/vkb/imageing-default

9aa7669

Fix imaging value for generating sysimages for multiple targets (cherry picked from commit fc4b079)

bump SparseArrays to latest v1.9

f7d8e20

N5N3 and others added 2 commits April 14, 2023 07:57

Subtype: fix union estimation on non-type parameters. (#49345)

6d03913

(cherry picked from commit fdd71c7)

Rename ipython_mode to numbered_prompt (#49314)

3ece193

Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com> Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com> (cherry picked from commit 99c0dad)

PallHaraldsson mentioned this pull request Apr 14, 2023

Can we rely on nanosoldier (from 1.9.0 run)? #49356

Closed

InteractiveUtils: use quoted typesof in macroexpansion (#47626)

304037b

fix #47606 (cherry picked from commit 553047f)

DilumAluthgeBot and others added 2 commits April 17, 2023 08:53

Bump the Pkg stdlib from 1b73599d2 to 3ca88658d (#49347)

b05b958

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>

Bump LLVM to 14.0.6-3

0033465

(cherry picked from commit 74a52cf)

ven-k mentioned this pull request Apr 19, 2023

Pass CPU targets as cmdline args JuliaLang/PackageCompiler.jl#804

Merged

N5N3 and others added 5 commits April 23, 2023 01:12

Subtype: Improve simple_meet resolution for Union inputs (#49376)

faeb43b

* Improve `simple_meet` resolution. * Fix for many-to-one cases. * Test disjoint via `jl_has_empty_intersection`

Enable the AVR backend of LLVM (#49006)

f89f5d9

Co-authored-by: Sukera <Seelengrab@users.noreply.github.com> (cherry picked from commit 4beea98)

prevent display in REPL from erroring on non standard prompts (#49383)

cbc4f49

(cherry picked from commit bb118c9)

make extension not load twice on workers (#49441)

7c6dd4c

(cherry picked from commit b1c0eac)

Extract specializations, 1.9-style (#49467)

29889c7

KristofferC force-pushed the backports-release-1.9 branch from 9e382e6 to 29889c7 Compare April 24, 2023 07:47

N5N3 and others added 4 commits April 24, 2023 16:32

Subtype: minor optimization for simple_intersect

a666aab

1. remove duplicated disjoint check. 2. add a fast path for all disjoint case. (cherry picked from commit f2560c2)

Merge pull request #49486 from JuliaLang/sf/backport_win_hang_fix

0a374d5

[release-1.9] Avoid usage of `jl_error()` in `check_cmdline()`

rename jl_tls_offset in sysimage to avoid naming clash with `libjul…

ad9b54f

…ia-internal` (#49442)

KristofferC merged commit 3d195c0 into release-1.9 Apr 25, 2023

KristofferC deleted the backports-release-1.9 branch April 25, 2023 14:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backports for 1.9.0 #49302

Backports for 1.9.0 #49302

KristofferC commented Apr 9, 2023 •

edited by N5N3

Loading

KristofferC commented Apr 13, 2023

nanosoldier commented Apr 13, 2023

KristofferC commented Apr 14, 2023

nanosoldier commented Apr 14, 2023

KristofferC commented Apr 15, 2023

timholy commented Apr 16, 2023

KristofferC commented Apr 16, 2023 •

edited

Loading

KristofferC commented Apr 22, 2023

nanosoldier commented Apr 23, 2023

KristofferC commented Apr 25, 2023

Backports for 1.9.0 #49302

Backports for 1.9.0 #49302

Conversation

KristofferC commented Apr 9, 2023 • edited by N5N3 Loading

KristofferC commented Apr 13, 2023

nanosoldier commented Apr 13, 2023

KristofferC commented Apr 14, 2023

nanosoldier commented Apr 14, 2023

KristofferC commented Apr 15, 2023

timholy commented Apr 16, 2023

KristofferC commented Apr 16, 2023 • edited Loading

KristofferC commented Apr 22, 2023

nanosoldier commented Apr 23, 2023

KristofferC commented Apr 25, 2023

KristofferC commented Apr 9, 2023 •

edited by N5N3

Loading

KristofferC commented Apr 16, 2023 •

edited

Loading