Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shield Base.require from invalidations when loading Symbolics.jl #49604

Merged
merged 1 commit into from
May 3, 2023
Merged

shield Base.require from invalidations when loading Symbolics.jl #49604

merged 1 commit into from
May 3, 2023

Conversation

KristofferC
Copy link
Sponsor Member

@KristofferC KristofferC commented May 2, 2023 •
edited

Otherwise:

inserting isequal(x, ::SymbolicUtils.Symbolic) @ SymbolicUtils ~/.julia/packages/SymbolicUtils/H684H/src/types.jl:189 invalidated:
   backedges: 1: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::String, ::Any) (22 children)

invalidates this.

@KristofferC KristofferC added compiler:latency Compiler latency backport 1.9 Change should be backported to release-1.9 labels May 2, 2023
@KristofferC KristofferC mentioned this pull request May 2, 2023
Merged
@KristofferC KristofferC merged commit 5039d8a into master May 3, 2023
4 checks passed
@KristofferC KristofferC deleted the kc/require_sym branch May 3, 2023 07:21
@jlapeyre jlapeyre mentioned this pull request May 5, 2023
Open
KristofferC added a commit that referenced this pull request May 8, 2023
@KristofferC
shield Base.require from invalidations when loading Symbolics.jl (#…
c9f59c9 
…49604)

(cherry picked from commit 5039d8a)
@KristofferC KristofferC mentioned this pull request May 8, 2023
Merged
51 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label May 28, 2023
kpamnany pushed a commit that referenced this pull request Jun 21, 2023
@KristofferC @kpamnany
shield Base.require from invalidations when loading Symbolics.jl (#…
54c4f59 
…49604)

(cherry picked from commit 5039d8a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timholy timholy timholy approved these changes

Assignees
No one assigned
Labels
compiler:latency Compiler latency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KristofferC @timholy