Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports for julia 1.9.1 #49680

Merged
merged 38 commits into from
May 28, 2023
Merged

Backports for julia 1.9.1 #49680

merged 38 commits into from
May 28, 2023

Conversation

KristofferC
Copy link
Sponsor Member

@KristofferC KristofferC commented May 8, 2023

Backported PRs:

Need manual backport:

Contains multiple commits, manual intervention needed:

Non-merged PRs with backport label:

Azzaare and others added 8 commits May 8, 2023 09:14
Removes the duplicate header `Synchronization`

(cherry picked from commit 7ddb4e5)
* Nospecialize close(c::Channel, excp::Exception) on excp.

Fixes #49507.

Avoids dynamic dispatch when closing a Channel with an Exception, and
should avoid a call into the runtime for julia compilation when
attempting to report an exception.

* Add test for this case.

(cherry picked from commit a152d11)
(cherry picked from commit 9bb0731)
@KristofferC KristofferC added the kind:release Release management and versioning. label May 8, 2023
@KristofferC
Copy link
Sponsor Member Author

@nanosoldier runtests(vs=":release-1.9")

@nanosoldier
Copy link
Collaborator

Your job failed. Consult the server logs for more details (cc @maleadt).

@maleadt
Copy link
Member

maleadt commented May 16, 2023

@nanosoldier runtests(vs=":release-1.9")

@nanosoldier
Copy link
Collaborator

Your job failed. Consult the server logs for more details (cc @maleadt).

@maleadt
Copy link
Member

maleadt commented May 16, 2023

Forgot to restart the server after my bugfix... Let's try again:

@nanosoldier runtests(vs=":release-1.9")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

@KristofferC
Copy link
Sponsor Member Author

@nanosoldier runtests(vs=":release-1.9")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

@KristofferC
Copy link
Sponsor Member Author

@nanosoldier runtests(["Evolutionary", "Test", "Probably", "QuantumCumulants", "HarmonicBalance", "MPIMeasurements", "NNlib", "OptimizationMetaheuristics", "Comrade", "GADM", "FractalDimensions", "SmartML", "AlgebraicRL", "Dynesty", "ReactiveMP", "ModelingToolkit"], vs = ":release-1.9")

@Bo98
Copy link

Bo98 commented May 20, 2023

Can I request a backport of this one line: 1e5fdb2#diff-5367a24cd5303d6218f61148f2db355c3f3c682ec003630cf9730fa02b8d8429L1056-R1084? I believe this to be the cause of #49895, and the change should be compatible with the older MPFR version used in 1.9.

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

@KristofferC
Copy link
Sponsor Member Author

@nanosoldier runtests(vs=":release-1.9")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

@KristofferC
Copy link
Sponsor Member Author

@aviatesk, do you understand https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/d105b83_vs_8e63055/ControlSystems.primary.log?

Internal error: encountered unexpected error in runtime:
MethodError(f=Core.Compiler.widenconst, args=(_copyto_impl!(Array{Int64, 2}, Int64, Array{Int64, 2}, Int64, Int64) from _copyto_impl!(Array{T, N} where N where T, Integer, Array{T, N} where N where T, Integer, Integer),), world=0x00000000000014db)
jl_method_error_bare at /cache/build/default-amdci5-6/julialang/julia-release-1-dot-9/src/gf.c:2076
jl_method_error at /cache/build/default-amdci5-6/julialang/julia-release-1-dot-9/src/gf.c:2094
jl_lookup_generic_ at /cache/build/default-amdci5-6/julialang/julia-release-1-dot-9/src/gf.c:2921 [inlined]
ijl_apply_generic at /cache/build/default-amdci5-6/julialang/julia-release-1-dot-9/src/gf.c:2936
widen_all_consts! at ./compiler/typeinfer.jl:596
ir_to_codeinf! at ./compiler/optimize.jl:182 [inlined]
transform_result_for_cache at ./compiler/typeinfer.jl:373 [inlined]
cache_result! at ./compiler/typeinfer.jl:404
_typeinf at ./compiler/typeinfer.jl:293
typeinf at ./compiler/typeinfer.jl:216
typeinf_edge at ./compiler/typeinfer.jl:933
abstract_call_method at ./compiler/abstractinterpretation.jl:611
abstract_call_gf_by_type at ./compiler/abstractinterpretation.jl:152
abstract_call_known at ./compiler/abstractinterpretation.jl:1949
abstract_call at ./compiler/abstractinterpretation.jl:2020
abstract_call at ./compiler/abstractinterpretation.jl:1999
abstract_eval_statement_expr at ./compiler/abstractinterpretation.jl:2183
abstract_eval_statement at ./compiler/abstractinterpretation.jl:2396
abstract_eval_basic_statement at ./compiler/abstractinterpretation.jl:2684
typeinf_local at ./compiler/abstractinterpretation.jl:2869

@aviatesk
Copy link
Sponsor Member

I can look into it tomorrow.

@aviatesk
Copy link
Sponsor Member

@aviatesk, do you understand https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/d105b83_vs_8e63055/ControlSystems.primary.log?

Hmm, I couldn't reproduce it on both mac and Linux. Let me run it again:
@nanosoldier runtests(["ControlSystems"], vs=":release-1.9")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - no new issues were detected.
A full report can be found here.

@aviatesk
Copy link
Sponsor Member

The error seems to have disappeared:)

staticfloat and others added 24 commits May 27, 2023 21:36
…definitions in ecosystem (#49603)

(cherry picked from commit 43c9202)
LLVM does this already.

(cherry picked from commit b815bb1)
* Update calling-c-and-fortran-code.md Drop mentioning Cxx.jl

(cherry picked from commit e998367)
…nt's load path (#49701)

also allow loading extensions of the active project

(cherry picked from commit d55314c)
* Disable slow path to handle Union explosion

* 3 tests are broken due to disabling slow path
Regression caused by #41742, which inverted the loop without inverting
the logic. And fix a number of related formatting mistakes.

Fix #49732

(cherry picked from commit 45748b8)
It appears that we were assuming our path was initialized with zeros, but that is not a safe assumption.

(cherry picked from commit 7111597)
(cherry picked from commit 7c24cc6)
#49812 introduced a bug and broke the CI.
This commit fixes it up.

(cherry picked from commit 869c70e)
- atexit(f) mutates global shared state.
- atexit(f) can be called anytime by any thread.
- Accesses & mutations to global shared state must be locked if they can
  be accessed from multiple threads.

Add unit test for thread safety of adding many atexit functions in
parallel

(cherry picked from commit 9dd3090)
Don't depend on `CompilerSupportLibraries_jll` from `OpenBLAS_jll`

(cherry picked from commit 98b64b2)
Co-authored-by: Simon Byrne <simon.byrne@gmail.com>
…b9f9 (#49926)

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
This should be slightly more efficient as the compiler now only tries to call
`iterate` on `t` and `s` once, and will not try to destructure the result if
the `iterate` call returns `nothing`.
This change reduce spurious JET warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:release Release management and versioning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet