Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the 1.9.1-full tarball #50252

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Conversation

kpamnany
Copy link
Contributor

@kpamnany kpamnany commented Jun 21, 2023

See commits.

Fixes for aarch64-darwin still to come. It is actually x86_64-darwin that is still failing and needs a fix.

Closes #46530. Please confirm @benlorenz? Partially reverts #46061. Cc: @maleadt
Closes #50127.

Related: JuliaLang/llvm-project#18

This makes it so libgit2.so and libssh2.so go into `usr/lib` where they
should be, rather than into `usr/lib64` on some platforms.
@vchuravy vchuravy added domain:building Build system, or building Julia or its dependencies kind:bugfix This change fixes an existing bug backport 1.9 Change should be backported to release-1.9 labels Jun 21, 2023
@staticfloat staticfloat merged commit 6a6504e into backports-release-1.9 Jun 21, 2023
3 of 5 checks passed
@staticfloat staticfloat deleted the kp/fixes-191-full branch June 21, 2023 23:45
@benlorenz
Copy link
Contributor

Closes #46530. Please confirm @benlorenz?

I can confirm this fixes the issue I reported and the build works fine on this branch.
Will this be ported to master as well?

@kpamnany
Copy link
Contributor Author

Uh. Yes. It should be on master as well. I'll open another PR.

@kpamnany kpamnany mentioned this pull request Jun 22, 2023
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Jun 22, 2023
@KristofferC KristofferC mentioned this pull request Jun 26, 2023
36 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:building Build system, or building Julia or its dependencies kind:bugfix This change fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants