[ittapi] Check out branch only if ITTAPI is cloned #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This didn't work correctly with the changes I made to |
Use `${ITTAPI_SOURCE_DIR}` rather than `${ITTAPI_SOURCE_DIR}/ittapi` for
the ITTAPI location.
Check out the `${ITTAPI_GIT_TAG}` only if ITTAPI is cloned because when
building from a tarball (as opposed to an online build),
`${ITTAPI_SOURCE_DIR}` is not a repository so we shouldn't try to check
out a branch.
|
Okay, this seems to work (from here). Alternatively it could be put in |
|
Ideally we would submit this first upstream. |
|
LLVM doesn't yet use GitHub pull-request, but hopefully will starting this fall,. https://llvm.org/docs/Contributing.html#id9 for how to submit a patch. |
|
Closing this PR as this we moved forward with our LLVM version, and this PR is also targeting the wrong branch, should use one of our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building from a tarball (as opposed to an online build),
ittapiis not a repository so we shouldn't try to check out a branch.