Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SuiteSparse_jll: onlydlopen the libraries if Base.USE_GPL_LIBS is true #50267

Merged
merged 2 commits into from Jun 24, 2023
Merged

SuiteSparse_jll: onlydlopen the libraries if Base.USE_GPL_LIBS is true #50267

merged 2 commits into from Jun 24, 2023

Conversation

DilumAluthge
Copy link
Member

No description provided.

@DilumAluthge DilumAluthge added domain:arrays:sparse Sparse arrays kind:bugfix This change fixes an existing bug backport 1.6 Change should be backported to release-1.6 backport 1.9 Change should be backported to release-1.9 labels Jun 22, 2023
@DilumAluthge
Copy link
Member Author

cc: @kpamnany

@kpamnany
Copy link
Contributor

Thank you @DilumAluthge! I'm confirming that this fixes things... will report back.

kpamnany
kpamnany approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@kpamnany kpamnany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to fix our problem! Thanks!

@kpamnany kpamnany added the status:merge me PR is reviewed. Merge when all tests are passing label Jun 22, 2023
@DilumAluthge DilumAluthge merged commit f2c6580 into master Jun 24, 2023
6 checks passed
@DilumAluthge DilumAluthge deleted the dpa/suitesparse-jll branch June 24, 2023 03:42
@DilumAluthge DilumAluthge removed the status:merge me PR is reviewed. Merge when all tests are passing label Jun 24, 2023
KristofferC pushed a commit that referenced this pull request Jun 26, 2023
@DilumAluthge @KristofferC
SuiteSparse_jll: onlydlopen the libraries if Base.USE_GPL_LIBS …
e46ce26 
…is true (#50267)

(cherry picked from commit f2c6580)
@KristofferC KristofferC mentioned this pull request Jun 26, 2023
Merged
36 tasks
@bmmogensen bmmogensen mentioned this pull request Jun 27, 2023
Closed
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Jun 29, 2023
@DilumAluthge @kpamnany
SuiteSparse_jll: onlydlopen the libraries if Base.USE_GPL_LIBS …
6cd1320 
…is true (JuliaLang#50267)
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Jul 10, 2023
@KristofferC KristofferC mentioned this pull request Oct 11, 2023
Open
78 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViralBShah ViralBShah ViralBShah approved these changes

@kpamnany kpamnany kpamnany approved these changes

@staticfloat staticfloat Awaiting requested review from staticfloat

Assignees
No one assigned
Labels
backport 1.6 Change should be backported to release-1.6 domain:arrays:sparse Sparse arrays kind:bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DilumAluthge @kpamnany @ViralBShah @KristofferC