Update SuiteSparse_jll.jl to skip only GPL libraries #50302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only skip dlopen for the libraries that actually are GPL.
|
I sometimes forget that not all of SuiteSparse is GPL. However, the way our build system works is that if USE_GPL_LIBS is set to false in the build/install, then none of SuiteSparse will be built or installed. Hence this should stay the way it is. Line 144 in ba0e484 |
ViralBShah
added
domain:building
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#50267 skipped dlopen for all SuiteSparse libraries.
This PR suggests to only skip dlopen for the libraries that actually are GPL. @DilumAluthge