-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-1.9: Backports for 1.9.3 #50507
Commits on Jul 11, 2023
-
Generalize Bool parse method to AbstractString (#47782)
* Generalize Bool parse method to AbstractString Fixes JuliaStrings/InlineStrings.jl#57. We currently have a specialization for `parse(Bool, ::Union{String, SubString{String})` where `true` and `false` are parsed appropriately. The restriction to `Union{String, SubString{String}}`, however, means we don't get this behavior for other `AbstractString`s. In the linked issue above, for InlineStrings, we end up going through the generic integer parsing codepath which results in an `InexactError` when we try to do `Bool(10)`. The proposal in this PR takes advantage of the fact that there is only the 2 comparisons where we do `_memcmp` that require the input string to be "dense" (in memory), and otherwise, we just do a comparison against a `SubString` of the input string. Relatedly, I've wanted to introduce the concept of an abstrac type like: ```julia abstract type MemoryAddressableString <: AbstractString ``` where the additional required interface would be being able to call `pointer(::MemoryAddressableString)`, since a lot of our string algorithms depend on doing these kind of pointer operations and hence makes it quite a pain to implement your own custom string type. * Apply suggestions from code review Co-authored-by: Stefan Karpinski <stefan@karpinski.org> Co-authored-by: Nick Robinson <npr251@gmail.com> Co-authored-by: Stefan Karpinski <stefan@karpinski.org> Co-authored-by: Nick Robinson <npr251@gmail.com> (cherry picked from commit 63830a6)
Configuration menu - View commit details
-
Copy full SHA for c984dd8 - Browse repository at this point
Copy the full SHA c984dd8View commit details -
Lock finalizers lists at exit (#49931)
(cherry picked from commit c470dc3)
Configuration menu - View commit details
-
Copy full SHA for 6d135d6 - Browse repository at this point
Copy the full SHA 6d135d6View commit details -
Check input expresion in numbered prompt (#50064)
(cherry picked from commit 7e3c706)
Configuration menu - View commit details
-
Copy full SHA for f297ae2 - Browse repository at this point
Copy the full SHA f297ae2View commit details -
docs: Fix a
!!! note
which was miscapitalized (#50474)(cherry picked from commit 236c23b)
Configuration menu - View commit details
-
Copy full SHA for d574712 - Browse repository at this point
Copy the full SHA d574712View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8eabb7 - Browse repository at this point
Copy the full SHA a8eabb7View commit details
Commits on Aug 10, 2023
-
Fix visibility of assert on GCC12/13
(cherry picked from commit 28720ff)
Configuration menu - View commit details
-
Copy full SHA for 8b99260 - Browse repository at this point
Copy the full SHA 8b99260View commit details -
versioninfo()
: include build info and unofficial warning (#50635)(cherry picked from commit c43e5a1)
Configuration menu - View commit details
-
Copy full SHA for 1d2dd91 - Browse repository at this point
Copy the full SHA 1d2dd91View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9543ef - Browse repository at this point
Copy the full SHA b9543efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 593dcde - Browse repository at this point
Copy the full SHA 593dcdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a5d1d4 - Browse repository at this point
Copy the full SHA 7a5d1d4View commit details -
Update URLs to JuliaHub blog (cherry picked from commit abae35c)
Configuration menu - View commit details
-
Copy full SHA for 0de8c64 - Browse repository at this point
Copy the full SHA 0de8c64View commit details -
initialize prev_nold and nold in gc_reset_page (#50289)
(cherry picked from commit 48c92c1)
Configuration menu - View commit details
-
Copy full SHA for e2208a7 - Browse repository at this point
Copy the full SHA e2208a7View commit details -
Expand kwcall lowering positional default check to vararg
Fixes the case from #50518, but we actually have two test cases in the tests that also hit this (e.g. this one: ``` f40964(xs::Int...=1; k = 2) = (xs, k) ```), but just happened not to hit the bad codegen path. #50556, once merged would have complained on those definitions as well, without this fix. (cherry picked from commit c272236)
Configuration menu - View commit details
-
Copy full SHA for 0c9c477 - Browse repository at this point
Copy the full SHA 0c9c477View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0ade8a - Browse repository at this point
Copy the full SHA f0ade8aView commit details -
invokelatest docs should say not exported before 1.9 (#50341)
(cherry picked from commit cb6d0f2)
Configuration menu - View commit details
-
Copy full SHA for 15f417f - Browse repository at this point
Copy the full SHA 15f417fView commit details -
Merge pull request #50525 from oscardssmith/fix-generic_lu_fact-check…
…=false only check that values are finite in `generic_lufact` when `check=true` (cherry picked from commit 824cdf1)
Configuration menu - View commit details
-
Copy full SHA for 5f465da - Browse repository at this point
Copy the full SHA 5f465daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 016cb5f - Browse repository at this point
Copy the full SHA 016cb5fView commit details -
Add
Base.get_extension
to docs/API (#50860)The documentation of `Pkg.jl` is instructing developers to rely on the existence of this function, and there doesn't seem to be any alternative which is a part of the API that developers can use instead on to guarantee forward compatibility for the same behavior. `Base.get_extension` is [referred to explicitly](https://pkgdocs.julialang.org/v1.9/creating-packages/#Backwards-compatibility) in the `Pkg.jl` docs to conditionally use package extensions vs `Requires.jl`. The `Pkg.jl` docs suggest ```julia if !isdefined(Base, :get_extension) include("../ext/PlottingContourExt.jl") end ``` to transition from "normal dependency to extension," which will break and automatically load the extension in future versions should `Base.get_extension` go away. `Base.get_extension` is the only way (that I know of) to directly access the module associated with a package extension, which can be a useful utility as well. (cherry picked from commit d1759bc)
Configuration menu - View commit details
-
Copy full SHA for bba08a4 - Browse repository at this point
Copy the full SHA bba08a4View commit details -
Backport: Avoid generic call in most cases for getproperty (#50523)
(cherry picked from commit 462ac49)
Configuration menu - View commit details
-
Copy full SHA for 88ece46 - Browse repository at this point
Copy the full SHA 88ece46View commit details -
Array(::AbstractRange)
should return anArray
(#50568)Currently, `Array(r::AbstractRange)` falls back to `vcat(r)`, but certain ranges may choose to specialize `vcat(r::AbstractRange)` to not return an `Array`. This PR ensures that `Array(r)` always returns an `Array`. At present, there's some code overlap with `vcat` (just above the `Array` method added in this PR). Perhaps some of these may be replaced by `unsafe_copyto!`, but the tests for ranges include some special cases that don't support `getindex`, which complicates things a bit. I've not done this for now. In any case, the common bit of code is pretty simple, so perhaps the duplication is harmless. (cherry picked from commit 3cc0590)
Configuration menu - View commit details
-
Copy full SHA for 025ef93 - Browse repository at this point
Copy the full SHA 025ef93View commit details
Commits on Aug 11, 2023
-
macOS: Don't inspect dead threadtls during exception handling. (#50871)
Otherwise we may end up with the state of a dead thread, as the system IDs can alias. This can lead to an early return from the exception handler, resulting in e.g. safepoint exceptions being actually delivered to user code. --------- Co-authored-by: Jameson Nash <vtjnash@gmail.com> Co-authored-by: Cody Tapscott <topolarity@tapscott.me>
Configuration menu - View commit details
-
Copy full SHA for ab27a43 - Browse repository at this point
Copy the full SHA ab27a43View commit details
Commits on Aug 14, 2023
-
Faster iteration over non-offset
AbstractVector
(#48720)This change simplifies the boundscheck in loop as LLVM would lift the const subtraction. Simd block would be generated in more cases. Co-authored-by: N5N3 <2642243996@qq.com> (cherry picked from commit 1543cdd)
Configuration menu - View commit details
-
Copy full SHA for c25c2bc - Browse repository at this point
Copy the full SHA c25c2bcView commit details