atexit: move hook before precompile output #51849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
approved these changes
Oct 24, 2023
This comment was marked as outdated.
This comment was marked as outdated.
vtjnash
force-pushed
the
jn/earlier-atexit-hook
branch
2 times, most recently
from
99b2d96
to
5a0a467
Compare
vtjnash
force-pushed
the
jn/earlier-atexit-hook
branch
from
3bba632
to
5944c7a
Compare
vtjnash
force-pushed
the
jn/earlier-atexit-hook
branch
from
5944c7a
to
ec65b41
Compare
vtjnash
force-pushed
the
jn/earlier-atexit-hook
branch
from
ec65b41
to
b5ca46c
Compare
vtjnash
added
merge me
Exposed by the presence of any atexit hooks in the new process, such as added in this PR.
To show how this is used, this updates the profile_printing_listener background job to use this mechanism. Also ensure mktemp and mktempdir cleanup even on unexpected exit: Previously this was relying on all Tasks running to completion, which is not a good assumption. Add the atexit hook, so that even if they do not run to completion, they still get cleaned up.
vtjnash
force-pushed
the
jn/earlier-atexit-hook
branch
from
b5ca46c
to
d8a410c
Compare
vtjnash
added
merge me
|
Just asking, will this be backported to 1.10? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To show how this is used, this updates the profile_printing_listener background job to use this mechanism.