Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence noisy test in test/cmdlineargs.jl #52225

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Silence noisy test in test/cmdlineargs.jl #52225

merged 1 commit into from
Nov 20, 2023

Conversation

giordano
Copy link
Contributor

@giordano giordano commented Nov 18, 2023 •
edited
Loading

This is spamming (example)

      From worker 12:	ERROR: LoadError: UndefVarError: `@which` not defined in `Main`
      From worker 12:	Stacktrace:
      From worker 12:	 [1] top-level scope
      From worker 12:	   @ :0
      From worker 12:	 [2] lower
      From worker 12:	   @ ./meta.jl:163 [inlined]
      From worker 12:	 [3] eval_user_input(errio::IOContext{Base.PipeEndpoint}, ast::Any, show_value::Bool)
      From worker 12:	   @ Base ./client.jl:141
      From worker 12:	 [4] run_main_repl(interactive::Bool, quiet::Bool, banner::Symbol, history_file::Bool, color_set::Bool)
      From worker 12:	   @ Base ./client.jl:477
      From worker 12:	 [5] repl_main
      From worker 12:	   @ Base ./client.jl:561 [inlined]
      From worker 12:	 [6] _start()
      From worker 12:	   @ Base ./client.jl:535
      From worker 12:	in expression starting at none:1

in all jobs

@giordano giordano added test This change adds or pertains to unit tests domain:ci Continuous integration labels Nov 18, 2023
Keno
Keno reviewed Nov 18, 2023
View reviewed changes
test/cmdlineargs.jl Outdated Show resolved Hide resolved
giordano
giordano commented Nov 18, 2023
View reviewed changes
test/cmdlineargs.jl Outdated Show resolved Hide resolved
Keno
Keno reviewed Nov 20, 2023
View reviewed changes
test/cmdlineargs.jl Outdated Show resolved Hide resolved
@vtjnash
Copy link
Sponsor Member

vtjnash commented Nov 20, 2023

Why is this test regressed however? It wasn't broken in the last release

@giordano
Copy link
Contributor Author

It was marked as broken by #51399 (excision of REPL)

@giordano giordano merged commit 67161a3 into JuliaLang:master Nov 20, 2023
7 checks passed
@giordano giordano deleted the mg/silence-cmdlineargs branch November 20, 2023 17:10
mkitti pushed a commit to mkitti/julia that referenced this pull request Dec 9, 2023
@giordano @mkitti
Silence noisy test in test/cmdlineargs.jl (JuliaLang#52225)
420dfe9 
This is spamming
([example](https://buildkite.com/julialang/julia-master/builds/30247#018be235-0cd3-43bb-ba43-cc378ac0d682/792-1056))
```
      From worker 12:	ERROR: LoadError: UndefVarError: `@which` not defined in `Main`
      From worker 12:	Stacktrace:
      From worker 12:	 [1] top-level scope
      From worker 12:	   @ :0
      From worker 12:	 [2] lower
      From worker 12:	   @ ./meta.jl:163 [inlined]
      From worker 12:	 [3] eval_user_input(errio::IOContext{Base.PipeEndpoint}, ast::Any, show_value::Bool)
      From worker 12:	   @ Base ./client.jl:141
      From worker 12:	 [4] run_main_repl(interactive::Bool, quiet::Bool, banner::Symbol, history_file::Bool, color_set::Bool)
      From worker 12:	   @ Base ./client.jl:477
      From worker 12:	 [5] repl_main
      From worker 12:	   @ Base ./client.jl:561 [inlined]
      From worker 12:	 [6] _start()
      From worker 12:	   @ Base ./client.jl:535
      From worker 12:	in expression starting at none:1
```
in all jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
domain:ci Continuous integration test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giordano @vtjnash @Keno