Ensure that annotations are well-ordered in optimisation #53800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function annotatedstring_optimize! assumes, but does not ensure that annotations are well ordered. For a small (~2%) performance cost, we can ensure that annotations are indeed well-ordered, which seems worthwhile.
|
Let me know if I'm being too ambitious, but I'm going to speculatively tag this with |
tecosaur
added
backport 1.11
59 tasks
tecosaur
removed
status:awaiting review
|
After a long chat with @LilithHafner, we're going to be taking a different approach to this. A superseding PR should be up shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on from #53794 (which needs to be merged before this PR) that largely seems like a "might as well" type thing to me.
See the commit message for more details.
A cosmetic change this has me considering is whether it would be nice to rename this function to
annotatedstring_normalize!. Thoughts?