Normalise annotations on AnnotatedIOBuffer read #53801
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is easy to come across situations where content with the same styling is consecutively written to an AnnotatedIOBuffer, resulting in what could be one region with a certain style being represented with many identical regions instead. This is entirely valid, and handled correctly, but it is much nicer in a number of respects if any such regions are consolidated. The annotatedstring_optimize! function does exactly this, and so we apply it to the AnnotatedString result when reading from an AnnotatedIOBuffer.
|
Let me know if I'm being too ambitious, but I'm going to speculatively tag this with |
tecosaur
added
backport 1.11
59 tasks
tecosaur
removed
status:awaiting review
|
After a long chat with @LilithHafner, we're going to be taking a different approach to this. A superseding PR should be up shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the batch of polishing I'm currently working on (see also: #53715, #53794, #53800), this seems like another tweak worth making.
See the commit message for more details.