[LBT] Upgrade to v5.9.0 #54361
[LBT] Upgrade to v5.9.0 #54361
Conversation
|
|
||
| [deps] | ||
| Libdl = "8f399da3-3557-5675-b5ff-fb832c97cbdb" | ||
| Artifacts = "56f22d72-fd6d-98f1-02f0-08ddc0907c33" | ||
|
|
||
| [compat] | ||
| julia = "1.10" | ||
| julia = "1.11" |
There was a problem hiding this comment.
If you want to change this, it's 1.12, not 1.11, no?
There was a problem hiding this comment.
I was not sure because Julia 1.11 was not released yet.
But I think that 1.12 is better and we can backport it later.
There was a problem hiding this comment.
Feature freeze of 1.11 was long ago and binary dependencies are usually not backported, unless there's a compelling reason to do that (security fixes, real bug fixing, etc...)
There was a problem hiding this comment.
I recall that Viral requested twice to backport a new release of LBT: #49281 (comment)
I thought it was common. 😅
There was a problem hiding this comment.
My two cents for backporting this PR are that it changes very little and is low risk - but adds the ability to use various new symbols. Probably any breakage can be fixed very quickly. Would certainly be nice to backport to 1.11.
What was the decision on backporting, since I see this doesn't have a backport label applied. There don't appear to have been any issues in since this was added, so should we mark it as backportable so 1.11 gets the newer LAPACK functions as well? |
|
I see @giordano 's note above now and agree that this would not be commonplace, but IMO, these changes to LBT 5.9 are really tiny. I would love it if LBT 5.9 can be considered for 1.11. I'm marking it for backport so that at least the triage team can actively consider and decide (either way). |
|
If this bump is considered too large, would it be possible to consider a patch release to the LBT release that ships in 1.11 that only adds to the list of exported symbols? |
The bulk of the diff for 5.8.0 to 5.9.0 is basically just adding the symbols, so I don't think there is much to leave out from a slimmed down version. The only thing that we need to be careful of is the makefile change I guess, but it looks like it should be fine by my glance. |
(cherry picked from commit 9d8e0e7)
|
This changed the julia compat from 1.10 to 1.12 which is not satisfied on 1.11 so this cannot be backported as is. I am not sure why that change was made though. Edit: I see this was already discussed in #54361 (comment) |
KristofferC
removed
the
backport 1.11
This reverts commit 0df6f80.
Backported PRs: - [x] #54361 <!-- [LBT] Upgrade to v5.9.0 --> - [x] #54474 <!-- Unalias source from dest in copytrito --> - [x] #54548 <!-- Fixes for bitcast bugs with LLVM 17 / opaque pointers --> - [x] #54191 <!-- make `AbstractPipe` public --> - [x] #53402 <!-- Add `jl_getaffinity` and `jl_setaffinity` --> - [x] #53356 <!-- Rename at-scriptdir project argument to at-script and search upwards for Project.toml --> - [x] #54545 <!-- typeintersect: fix incorrect innervar handling under circular env --> - [x] #54586 <!-- Set storage class of julia globals to dllimport on windows to avoid auto-import weirdness. Forward port of #54572 --> - [x] #54587 <!-- Accomodate for rectangular matrices in `copytrito!` --> - [x] #54617 <!-- CLI: Use `GetModuleHandleExW` to locate libjulia.dll --> - [x] #54605 <!-- Allow libquadmath to also fail as it is not available on all systems --> - [x] #54634 <!-- Fix trampoline assembly for build on clang 18 on apple silicon --> - [x] #54635 <!-- Aggressive constprop in trevc! to stabilize triangular eigvec --> - [x] #54645 <!-- ensure we set the right value to gc_first_tid --> - [x] #54554 <!-- make elsize public --> - [x] #54648 <!-- Construct LazyString in error paths for tridiag --> - [x] #54658 <!-- fix missing uuid check on extension when finding the location of an extension --> - [x] #54594 <!-- Switch to Pkg mode prompt immediately and load Pkg in the background --> - [x] #54669 <!-- Improve error message in inplace transpose --> - [x] #54671 <!-- Add boundscheck in bindingkey_eq to avoid OOB access due to data race --> - [x] #54672 <!-- make: Fix `sed` command for LLVM libraries with no symbol versioning --> - [x] #54624 <!-- more precise aliasing checks for SubArray --> - [x] #54679 <!-- 🤖 [master] Bump the Distributed stdlib from 6a07d98 to 6c7cdb5 --> - [x] #54604 <!-- Fix tbaa annotation on union selector bytes inside of structs --> - [x] #54690 <!-- Fix assertion/crash when optimizing function with dead basic block --> - [x] #54704 <!-- LazyString in reinterpretarray error messages --> - [x] #54718 <!-- fix prepend StackOverflow issue --> - [x] #54674 <!-- Reimplement dummy pkg prompt as standard prompt --> - [x] #54737 <!-- LazyString in interpolated error messages involving types --> - [x] #54642 <!-- Document GenericMemory and AtomicMemory --> - [x] #54713 <!-- make: use `readelf` for LLVM symbol version detection --> - [x] #54760 <!-- REPL: improve prompt! async function handler --> - [x] #54606 <!-- fix double-counting and non-deterministic results in `summarysize` --> - [x] #54759 <!-- REPL: Fully populate the dummy Pkg prompt --> - [x] #54702 <!-- lowering: Recognize argument destructuring inside macro hygiene --> - [x] #54678 <!-- Don't let setglobal! implicitly create bindings --> - [x] #54730 <!-- Fix uuidkey of exts in fast path of `require_stdlib` --> - [x] #54765 <!-- Handle no-postdominator case in finalizer pass --> - [x] #54591 <!-- Don't expose guard pages to malloc_stack API consumers --> - [x] #54755 <!-- [TOML] remove Dates hack, replace with explicit usage --> - [x] #54721 <!-- add try/catch around scheduler to reset sleep state --> - [x] #54631 <!-- Avoid concatenating LazyString in setindex! for triangular matrices --> - [x] #54322 <!-- effects: add new `@consistent_overlay` macro --> - [x] #54785 - [x] #54865 - [x] #54815 - [x] #54795 - [x] #54779 - [x] #54837 Contains multiple commits, manual intervention needed: - [ ] #52694 <!-- Reinstate similar for AbstractQ for backward compatibility --> - [ ] #54649 <!-- Less restrictive copyto! signature for triangular matrices --> Non-merged PRs with backport label: - [ ] #54779 <!-- make recommendation clearer on manifest version mismatch --> - [ ] #54739 <!-- finish implementation of upgradable stdlibs --> - [ ] #54738 <!-- serialization: fix relocatability bug --> - [ ] #54574 <!-- Make ScopedValues public --> - [ ] #54457 <!-- Make `String(::Memory)` copy --> - [ ] #53957 <!-- tweak how filtering is done for what packages should be precompiled --> - [ ] #53452 <!-- RFC: allow Tuple{Union{}}, returning Union{} --> - [ ] #53286 <!-- Raise an error when using `include_dependency` with non-existent file or directory --> - [ ] #51479 <!-- prevent code loading from lookin in the versioned environment when building Julia -->
I followed the instructions here.
ps: I found very old tarballs in
stdlib/libblastrampoline_jll/StdlibArtifacts.toml, what is the goal of this file?