make source-dist + git version info separation

[ivarne]

This is a rebase and combination of #5266 and #5095

I am not sure if @staticfloat has already based some of his nightly release effort on the previous work, so do not merge before he says this is still needed.

Unfortunately this might be a breaking change for code that depends on the Base.BUILD_INFO struct, because it has been renamed to Base.GIT_VERSION_INFO. Base.BUILD_INFO.version_string and Base.BUILD_INFO.TAGGED_RELEASE_BANNER has been put into a constant Base.VERSION_STRING and Base.TAGGED_RELEASE_BANNER.

I do not know how we might add a deprecation for these properties, but it would be possible to make a alias, so that packages who cares about compatibility can postpone their update until most users have this change.

[ivarne]

Unfortunately there is still a problem with readline patches that gets downloaded instead of being checked into our repository. As they do not match the pattern *.tar.gz or the other archive formats, they are currently not included, and the build fails.

[staticfloat]

Unfortunately there is still a problem with readline patches that gets downloaded instead of being checked into our repository.

These get downloaded via make -C deps getall, so they're already downloaded. Just change this line:

ls deps/*.tar.gz deps/*.tar.bz2 deps/*.tgz deps/random/*.tar.gz >> source-dist.tmp

To this:

ls deps/*.tar.gz deps/*.tar.bz2 deps/*.tgz deps/random/*.tar.gz deps/readline-* >> source-dist.tmp

And you should be good to go. Once you do that, I'll test this and merge it.

[ivarne]

Sorry, but that does not fix it. On my system the files are called readline62-00X.

This pattern matching files to include thing seems so funky. Nobody will know when they can remove anything, and it will not be discovered before someone tries build on a machine without internet (or if someone have a broken make rule that does not depend on the files downloaded). The *tar* rules seems fine, but I think the patches does not have unique enough names to be safe.

[staticfloat]

Whoops, yep. Meant to say readline62-, not readline-. In any case, adding the files to the repo seems just fine to me. This also works just fine, so I'ma merge it.