[release-1.11] fix GC race bug in pool sweep #55485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-netto
added
GC
d-netto
force-pushed
the
dcn-fix-gc-race-bug-in-pool-sweep
branch
from
b46f879
to
a0fafc3
Compare
gbaraldi
approved these changes
Aug 14, 2024
|
Generally better to do backports against the latest backport PR (#55344) because then it will go through PkgEval etc. |
vtjnash
added
the
status:merge me
oscardssmith
removed
the
status:merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have parallel sweeping on 1.11, so we should use atomics here.
This issue has already been fixed on master due to #54961.
We can also backport #54961 to release-1.11, but I have some preference to land this one since it's considerably less disruptive and we're already on RC2.