added findmax(A,dim) function to array.jl.

[floswald]

hi all,

this is my attempt at implementing my original feature request for a version of findmax that operates along a given index of an array.

I added some tests to test/reducedim.jl, although not entirely sure that's where they belong and how this needs to be set up to work with the full test suite.

[timholy]

Thanks for tackling this! I'll add a few comments.

[floswald]

Thanks for the comments Tim! So much to learn!

On 12 May 2014 13:32, Tim Holy notifications@github.com wrote:

Thanks for tackling this! I'll add a few comments.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/6816#issuecomment-42825964
.

[timholy]

It's one of the best things about submitting patches. I've learned a ton from my colleagues here.

[timholy]

@floswald, I don't mean to stand in the way of progress. I've got a free hour or two now, if you prefer I can pitch in. But if you're having fun learning, I certainly wouldn't want to take that away from you 😄. Keep the questions coming if you've got them.

[floswald]

Oh no please by all means do pitch in! I'm quite eager to see the proper solution to this problem. :-)
I'll come back with questions later if that's alright. Cheers!

Sent from my iPhone

On 18 May 2014, at 15:11, Tim Holy notifications@github.com wrote:

@floswald, I don't mean to stand in the way of progress. I've got a free hour or two now, if you prefer I can pitch in. But if you're having fun learning, I certainly wouldn't want to take that away from you . Keep the questions coming if you've got them.

—
Reply to this email directly or view it on GitHub.

[timholy]

See #6894

[floswald]

brilliant! thank you so much!
do you know when this piece of code will be available on the julia master branch (or is that not the right place to look for it)? cheers

[ViralBShah]

Yes, it will be on master as soon as the PR is merged.

[timholy]

Now available. Enjoy.