Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all trailing whitespace (again) #8914

Merged
merged 2 commits into from
Nov 6, 2014
Merged

Conversation

jakebolewski
Copy link
Member

No description provided.

jakebolewski added a commit that referenced this pull request Nov 6, 2014
Remove all trailing whitespace (again)
@jakebolewski jakebolewski merged commit ab1f287 into master Nov 6, 2014
@ivarne
Copy link
Sponsor Member

ivarne commented Nov 6, 2014

It doesn't look like your travis fail is working

It should've failed on the first commit, because it is tested before the commit where you clean everything up.

@jakebolewski
Copy link
Member Author

It looks like quotes are necessary to get this to work on Travis - "! git grep ...", I don't know why this is offhand.

@tkelman
Copy link
Contributor

tkelman commented Nov 24, 2014

@ivarne should we also remove trailing whitespace on release-0.3? I don't think that's been done yet and it looks like it might be causing some conflicts.

@ivarne
Copy link
Sponsor Member

ivarne commented Nov 24, 2014

Most definitely. If @jakebolewski remember the command he used, that would probably be a big timesaver.

@ivarne ivarne deleted the jcb/rmtrailingws branch November 24, 2014 19:35
@jakebolewski
Copy link
Member Author

This was the command I used

find . -not \(-prune -o -name .git -prune \) -type f -print0 | xargs -0 sed -i '' -E "s/[[:space:]]*$//"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants