Highlighting for macro calls and quoted symbols #9024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wilfred
force-pushed
the
highlight_symbols
branch
2 times, most recently
from
2f1eaa7
to
cf1f9af
Compare
|
I've pushed an improvement, so it now handles all the quoted symbols situations I can think of. I believe this is ready to merge, let me know if I need to make any changes. |
Wilfred
force-pushed
the
highlight_symbols
branch
from
cf1f9af
to
2886ab5
Compare
JeffBezanson
added a commit
that referenced
this pull request
Nov 30, 2014
Highlighting for macro calls and quoted symbols
|
I think it would make sense for quoted symbols to use constant-face by default; they are constants after all. Also quoted-symbol-face seems not to work right at the beginning of a line. This is definitely a pretty rare case though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit ensures that we use a different face for highlighting macro calls, so users may choose to style macro calls differently from keywords.
The second commit highlights quoted symbols, as we weren't doing that at all previously. It's not perfect (we can't handle all the different versions of
:endwithout a full parser) but it's very close.