-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Minimal cmake build script #28
Conversation
Tested, at least that it'll build the library, on MSVC and MinGW ( |
@@ -8,7 +8,6 @@ | |||
*.dll | |||
*.dylib | |||
*.dSYM | |||
*.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add data/*.txt
(or similar) back in, to exclude the Unicode data files that are downloaded there.
Don't move |
Also, can you add a test to the |
Also should have a |
Yeah. Will be a little annoying to have to remember to keep the Makefile and CmakeLists synchronized here, won't it? |
Why not just have CMakeLists.txt? |
If we make CMakeLists.txt do everything that the current Makefile does, sure. Should we just duplicate the info until that point? |
I would think so, assuming @stevengj is okay with that plan. |
59a601c
to
9a245ac
Compare
move flags for MSVC rename lump.txt to lump.md, add data/*.txt to .gitignore
only testing with default 32 bit MSVC and mingw.org at the moment add semicolons, fix quoting add fast fail functionality for redundant PR builds need separate folders for msvc vs mingw need to add path to mingw to /etc/fstab
In the long term, we can think about moving over to |
Will tkelman@ce053be suffice for now? See the travis/appveyor logs for what that does to the output file names. |
@tkelman, it looks like this is calling |
Only using |
The |
@tkelman, it sounds like |
only use ${SO_MAJOR} for cmake SOVERSION use 1.2.0 for version in cmake use only abi version for VERSION property in cmake
Okay, I did that. Now if only Travis would run. |
WIP: Minimal cmake build script
The
disallow_intree_builds()
snippet is thanks to Tracy Wadleigh. Tested on Linux, will check with MSVC/MinGW next.will close #23