Improve installation experience #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sneaks an `ENV["PATH"] = dirname(libmklrt)` into `Base.__init__()` to fix #6 * Adds an `MKL.enable_*_startup()` API, to enable re-setting to OpenBLAS
aminya
approved these changes
Oct 11, 2019
|
It works for me as well on Windows with Julia 1.2 but 1.0 fails. I'm getting the same error as the one reported on AppVeyor. There is also a warning that symlinks require admin privileges. |
|
I think I fixed |
delete-merged-branch
bot
deleted the
sf/improve_installation_experience
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves installation experience such that it can automatically add to PATH on windows to make up for the lack of RPATH on that platform. It also adds the ability to switch back to OpenBLAS, because there’s no reason to not have that ability. :)