Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manual mapping of non-suffixed APIs, which is fixed in MKL 2024.1 #167

Merged
merged 4 commits into from
May 16, 2024

Conversation

ViralBShah
Copy link
Contributor

@ViralBShah ViralBShah commented May 14, 2024

Discussion in #140 (comment).

Bumping to 2024.1 will also drop support for MKL on Mac, and threading tests fail on Julia 1.8. As a result Julia 1.9 is the new minimum. As a result, bumping the version to 0.7.

cc @amontoison

@amontoison
Copy link
Contributor

amontoison commented May 14, 2024

@ViralBShah
I am worried for #164 (comment).
I don't want to break things for Ipopt users.

@ViralBShah
Copy link
Contributor Author

I suppose I should just go ahead and remove macOS-13 from CI, since we no longer have support for macs. It would be nice if it just ended up with MKL_jll not available (like on macOS-14) rather than the Pkg error we get now.

@giordano
Copy link
Contributor

We can have a step which installs an older MKL_jll for macos-13.

@ViralBShah
Copy link
Contributor Author

ViralBShah commented May 14, 2024

We can have a step which installs an older MKL_jll for macos-13.

Those won't have the dlamch_64 etc. that only got done in 2024.1. I think folks who want Intel Macs may be best off using an older version of MKL.jl. Is there a way to make that happen?

We already have a note in the README: https://github.com/JuliaLinearAlgebra/MKL.jl?tab=readme-ov-file#note-mkl-on-intel-macs

@ViralBShah
Copy link
Contributor Author

We should probably add a couple of simple LP64 BLAS tests to make sure we don't regress.

@ViralBShah ViralBShah merged commit dff9406 into master May 16, 2024
@ViralBShah ViralBShah deleted the vs/ilp64 branch May 16, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants