-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check dimension of gram matrix #87
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
barucden
reviewed
Nov 8, 2021
barucden
reviewed
Nov 8, 2021
iblislin
reviewed
Nov 9, 2021
iblislin
reviewed
Nov 9, 2021
iblislin
reviewed
Nov 10, 2021
iblislin
approved these changes
Nov 10, 2021
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 86.56% 86.82% +0.26%
==========================================
Files 6 6
Lines 253 258 +5
==========================================
+ Hits 219 224 +5
Misses 34 34
Continue to review full report at Codecov.
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #85
Checks that the gram matrix supplied to
svmpredict
has dimensions(l, n)
when predictingn
items onl
training vectors or dimensions(k, n)
wherek
is the number of support vectors of the model. If neither is the case, it will throwDimensionMismatch
.I have marked this pull request as a draft since I haven't been using Julia for very long and would appreciate some oversight. Additionally, I think whether to allow
(k, n)
shaped matrices might warrant some additional discussion.