Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check dimension of gram matrix #87

Merged
merged 5 commits into from
Nov 11, 2021
Merged

Check dimension of gram matrix #87

merged 5 commits into from
Nov 11, 2021

Conversation

till-m
Copy link
Member

@till-m till-m commented Nov 5, 2021

Resolves #85
Checks that the gram matrix supplied to svmpredict has dimensions (l, n) when predicting n items on l training vectors or dimensions (k, n) where k is the number of support vectors of the model. If neither is the case, it will throw DimensionMismatch.

I have marked this pull request as a draft since I haven't been using Julia for very long and would appreciate some oversight. Additionally, I think whether to allow (k, n) shaped matrices might warrant some additional discussion.

@till-m till-m marked this pull request as ready for review November 5, 2021 07:51
@till-m till-m mentioned this pull request Nov 8, 2021
src/LIBSVM.jl Outdated Show resolved Hide resolved
src/LIBSVM.jl Outdated Show resolved Hide resolved
src/LIBSVM.jl Show resolved Hide resolved
src/LIBSVM.jl Show resolved Hide resolved
src/LIBSVM.jl Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2021

Codecov Report

Merging #87 (7e464f8) into master (b9f7a17) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   86.56%   86.82%   +0.26%     
==========================================
  Files           6        6              
  Lines         253      258       +5     
==========================================
+ Hits          219      224       +5     
  Misses         34       34              
Impacted Files Coverage Δ
src/LIBSVM.jl 93.42% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9f7a17...7e464f8. Read the comment docs.

@iblislin iblislin merged commit 2964e6b into JuliaML:master Nov 11, 2021
@iblislin
Copy link
Member

Thanks! 👍

@till-m till-m deleted the gram_dim_check branch November 11, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Kernels.Precomputed, svmpredict doesn't verify the dimensions of the input
4 participants