-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coerce fails with string colspec #194
Labels
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
Comments
Hello sir, I guess the above issue could be fixed just by adding a similar line like this
for defining a string , what do you think sir. |
I can just raise a PR on it |
Thank you @Jay-sanjay for considering a PR. Please try to follow the convention in other transforms that already use the |
Jay-sanjay
added a commit
to Jay-sanjay/TableTransforms.jl
that referenced
this issue
Sep 5, 2023
issue JuliaML#194 fixing
sir here is the link to the PR |
eliascarv
added a commit
that referenced
this issue
Sep 5, 2023
* Coerce fails with string colspec issue #194 fixing * Added test cases in coerce.jl * Update src/transforms/coerce.jl Co-authored-by: Elias Carvalho <73039601+eliascarv@users.noreply.github.com> * Update src/transforms/coerce.jl Co-authored-by: Elias Carvalho <73039601+eliascarv@users.noreply.github.com> * Update src/transforms/coerce.jl * removed comments --------- Co-authored-by: Elias Carvalho <73039601+eliascarv@users.noreply.github.com>
closed by #196 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
Currently we can
Coerce(:a => Multiclass)
, but we can'tCoerce("a" => Multiclass)
.The text was updated successfully, but these errors were encountered: