Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coerce fails with string colspec #194

Closed
juliohm opened this issue Sep 4, 2023 · 5 comments
Closed

Coerce fails with string colspec #194

juliohm opened this issue Sep 4, 2023 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@juliohm
Copy link
Member

juliohm commented Sep 4, 2023

Currently we can Coerce(:a => Multiclass), but we can't Coerce("a" => Multiclass).

@juliohm juliohm added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Sep 4, 2023
@Jay-sanjay
Copy link
Contributor

Hello sir, I guess the above issue could be fixed just by adding a similar line like this

Coerce(pair::Pair{Symbol,<:Type}...; tight=false, verbosity=1) = Coerce(pair, tight, verbosity)

for defining a string , what do you think sir.

@Jay-sanjay
Copy link
Contributor

I can just raise a PR on it

@juliohm
Copy link
Member Author

juliohm commented Sep 5, 2023

Thank you @Jay-sanjay for considering a PR.

Please try to follow the convention in other transforms that already use the ColSpec.

Jay-sanjay added a commit to Jay-sanjay/TableTransforms.jl that referenced this issue Sep 5, 2023
@Jay-sanjay
Copy link
Contributor

sir here is the link to the PR
#196

eliascarv added a commit that referenced this issue Sep 5, 2023
* Coerce fails with string colspec 
 issue #194  fixing

* Added test cases in coerce.jl

* Update src/transforms/coerce.jl

Co-authored-by: Elias Carvalho <73039601+eliascarv@users.noreply.github.com>

* Update src/transforms/coerce.jl

Co-authored-by: Elias Carvalho <73039601+eliascarv@users.noreply.github.com>

* Update src/transforms/coerce.jl

* removed comments

---------

Co-authored-by: Elias Carvalho <73039601+eliascarv@users.noreply.github.com>
@eliascarv
Copy link
Member

closed by #196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants