Coerce fails with string colspec #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue JuliaML#194 fixing
juliohm
requested changes
Sep 5, 2023
There was a problem hiding this comment.
Thank you @Jay-sanjay for the proposed fix. Can you please add tests as well?
|
yes sure , I will work on that |
eliascarv
reviewed
Sep 5, 2023
Co-authored-by: Elias Carvalho <73039601+eliascarv@users.noreply.github.com>
eliascarv
reviewed
Sep 5, 2023
Co-authored-by: Elias Carvalho <73039601+eliascarv@users.noreply.github.com>
eliascarv
reviewed
Sep 5, 2023
eliascarv
reviewed
Sep 5, 2023
test/transforms/coerce.jl
Outdated
| @@ -13,6 +13,7 @@ | |||
| @test eltype(tₒ.x1) == eltype(t.x1) | |||
| @test eltype(tₒ.x2) == eltype(t.x2) | |||
|
|
|||
| # Test for :a => Multiclass | |||
There was a problem hiding this comment.
I think comments are not necessary in this case.
eliascarv
reviewed
Sep 5, 2023
test/transforms/coerce.jl
Outdated
| @@ -22,6 +23,16 @@ | |||
| @test eltype(tₒ.x1) == eltype(t.x1) | |||
| @test eltype(tₒ.x2) == eltype(t.x2) | |||
|
|
|||
| # Test for "a" => Multiclass | |||
There was a problem hiding this comment.
I think comments are not necessary in this case.
eliascarv
approved these changes
Sep 5, 2023
|
Feel free to merge.
Em ter., 5 de set. de 2023 11:53, Elias Carvalho ***@***.***>
escreveu:
… @eliascarv <https://github.com/eliascarv> requested your review on: #196
<#196> Coerce fails
with string colspec.
—
Reply to this email directly, view it on GitHub
<#196 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZQW3ODQGEEEFIDFMVMGMDXY44FZANCNFSM6AAAAAA4LV37QU>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Thank you @Jay-sanjay ! Feel free to pick another one. We can guide you with tips and suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coerce fails with string colspec issue #194 fixing
--> Added extra line in coerce.jl for string implementation