Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Functional #60

Merged
merged 7 commits into from
Apr 29, 2022
Merged

New Functional #60

merged 7 commits into from
Apr 29, 2022

Conversation

eliascarv
Copy link
Member

@eliascarv eliascarv commented Apr 28, 2022

This PR redesigns Functional implementation to add support for applying functions to specific columns.
The following constructor has been added:

Functional(col₁ => func₁, col₂ => func₂, ..., colₙ => funcₙ)

closes #59

@eliascarv eliascarv requested a review from juliohm April 28, 2022 16:46
@eliascarv eliascarv changed the title New functional New Functional Apr 28, 2022
@juliohm
Copy link
Member

juliohm commented Apr 28, 2022

@eliascarv is this PR really ready for review? I got the notification but it seems like you are still working on it? There are many places still mentioning the single function signature.

@eliascarv
Copy link
Member Author

You're right, I'll switch to WIP.

@eliascarv eliascarv removed the request for review from juliohm April 28, 2022 17:00
@eliascarv eliascarv changed the title New Functional [WIP] New Functional Apr 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2022

Codecov Report

Merging #60 (1c7cae1) into master (c50d658) will decrease coverage by 3.16%.
The diff coverage is 35.71%.

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   92.84%   89.67%   -3.17%     
==========================================
  Files          19       19              
  Lines         461      494      +33     
==========================================
+ Hits          428      443      +15     
- Misses         33       51      +18     
Impacted Files Coverage Δ
src/transforms/functional.jl 61.22% <35.71%> (-32.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c50d658...1c7cae1. Read the comment docs.

@eliascarv eliascarv requested a review from juliohm April 28, 2022 17:32
@eliascarv eliascarv changed the title [WIP] New Functional New Functional Apr 28, 2022
@eliascarv
Copy link
Member Author

This PR is now ready for review @juliohm

src/transforms/functional.jl Outdated Show resolved Hide resolved
@eliascarv eliascarv requested a review from juliohm April 29, 2022 11:54
@juliohm juliohm merged commit 01364ef into master Apr 29, 2022
@juliohm juliohm deleted the new-functional branch April 29, 2022 13:14
@juliohm
Copy link
Member

juliohm commented Apr 29, 2022

Awesome 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specification of columns in Functional transform
3 participants