Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables.columnnames(table) => Tables.columnnames(cols) #63

Merged
merged 7 commits into from
Apr 29, 2022
Merged

Conversation

eliascarv
Copy link
Member

@eliascarv eliascarv commented Apr 29, 2022

closes #61

Copy link
Member

@juliohm juliohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing all these cases @eliascarv , can we also add a simple test for each transform using a row table? That way we make sure that we don't break things in the future.

@eliascarv
Copy link
Member Author

Note: I didn't add test for Select and Reject because their fix depends on PR #64.

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #63 (10c4219) into master (aaefe44) will decrease coverage by 0.09%.
The diff coverage is 93.10%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   92.46%   92.36%   -0.10%     
==========================================
  Files          19       19              
  Lines         491      498       +7     
==========================================
+ Hits          454      460       +6     
- Misses         37       38       +1     
Impacted Files Coverage Δ
src/colspec.jl 100.00% <ø> (ø)
src/transforms/eigenanalysis.jl 78.94% <66.66%> (-0.69%) ⬇️
src/transforms.jl 97.82% <100.00%> (ø)
src/transforms/coerce.jl 93.33% <100.00%> (ø)
src/transforms/filter.jl 98.03% <100.00%> (+0.03%) ⬆️
src/transforms/functional.jl 88.37% <100.00%> (ø)
src/transforms/parallel.jl 91.80% <100.00%> (+0.27%) ⬆️
src/transforms/rename.jl 100.00% <100.00%> (ø)
src/transforms/select.jl 91.78% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaefe44...10c4219. Read the comment docs.

@eliascarv eliascarv requested a review from juliohm April 29, 2022 18:15
@juliohm juliohm merged commit 17ea901 into master Apr 29, 2022
@juliohm juliohm deleted the col-names branch April 29, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behavior for row table
3 participants