Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign TableSelection implementation #64

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Conversation

eliascarv
Copy link
Member

This PR redesigns TableSelection implementation to accept RowTable.

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #64 (4ff4455) into master (01364ef) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   92.41%   92.46%   +0.04%     
==========================================
  Files          19       19              
  Lines         488      491       +3     
==========================================
+ Hits          451      454       +3     
  Misses         37       37              
Impacted Files Coverage Δ
src/transforms/select.jl 91.66% <100.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01364ef...4ff4455. Read the comment docs.

@eliascarv eliascarv merged commit aaefe44 into master Apr 29, 2022
@eliascarv eliascarv deleted the up-tableselection branch April 29, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants