Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for BoundaryValueDiffEq v5 #672

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Update for BoundaryValueDiffEq v5 #672

merged 2 commits into from
Oct 28, 2023

Conversation

mateuszbaran
Copy link
Member

This may resolve the never-ending solving problem on BoundaryValueDiffEq v5. Resolves #664 . Replaces #657 .

@mateuszbaran mateuszbaran added the Ready-for-Review A label for pull requests that are feature-ready label Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #672 (58c9681) into master (cdf3f6c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #672   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files         108      108           
  Lines       10599    10600    +1     
=======================================
+ Hits        10536    10537    +1     
  Misses         63       63           
Files Coverage Δ
ext/ManifoldsBoundaryValueDiffEqExt.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This even looks like a relatively easy fix in the end – are we sure the new tests run on v5? And then maybe check why we currently loose a bit of coverage.

But for the rest (besides of course a short note in the news) this looks nice!

@mateuszbaran
Copy link
Member Author

This even looks like a relatively easy fix in the end – are we sure the new tests run on v5? And then maybe check why we currently loose a bit of coverage.

Yes, Julia v1.9 tests run on BoundaryValueDiffEq v5 while Julia v1.6 tests run on BoundaryValueDiffEq v4. I just don't feel particularly good about tests running more than an hour 😞 .

Coverage loss looks like false positives.

@mateuszbaran mateuszbaran merged commit ab49d04 into master Oct 28, 2023
19 checks passed
@kellertuer kellertuer deleted the mbaran/bvproblem-5 branch May 4, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please update dep of BoundaryValueDiffEq.jl to v5.
2 participants